Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pod nodeSelector in the CRD #214

Closed
roivaz opened this issue Feb 26, 2024 · 8 comments
Closed

Expose pod nodeSelector in the CRD #214

roivaz opened this issue Feb 26, 2024 · 8 comments

Comments

@roivaz
Copy link

roivaz commented Feb 26, 2024

It would be nice if the field spec.template.spec.nodeSelector in the external-dns Deployment could be configurable by exposing this configuration via the ExternalDNS custom resource.
I am using the external-dns-operator in a cluster provisioned via hypershift. In this scenario the scheduler is unable to run external-dns pods because there are no master nodes available, so the pods stay in pending forever. The node selector is hardcoded here.
The workaround I'm appying is to remove the node-role.kubernetes.io/master: '' label from the nodeSelector in the Deployment object, as the operator seems to not reconcile this.

@alebedev87
Copy link
Contributor

alebedev87 commented Apr 10, 2024

@roivaz: Yes, the current node selector can cause a problem on HyperShift based deployments. Can you please file an RFE for the NetworkEdge team?

@Miciah
Copy link
Contributor

Miciah commented Apr 19, 2024

The feature request is now being tracked as RFE-5408

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2024
@alebedev87
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2024
@alebedev87
Copy link
Contributor

@roivaz: #219 relaxes the node selector by removing the master label.

@roivaz
Copy link
Author

roivaz commented Aug 6, 2024

@alebedev87 Thank you! That would definitely solve the issue. Any idea of the release this fix will be shipped in?

@alebedev87
Copy link
Contributor

The deadline is the GA of OpenShift 4.17, so beginning of October. However this operator is off the main payload so it can be released earlier.

@alebedev87
Copy link
Contributor

Closing the issue as the reporter confirmed #219 should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants