Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: support infoblox provider #124

Merged
merged 1 commit into from
Mar 31, 2022
Merged

e2e: support infoblox provider #124

merged 1 commit into from
Mar 31, 2022

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Mar 24, 2022 •
edited
Loading

Infoblox helper added.

Differences from the other (public) providers:

  • Credentials cannot be requested from CCO so they have to be provided explicitly: via environment variables
  • Init is more complex because the self signed certificate of the Infoblox (currently manually deployed) has to be trusted
  • Some operations can not be done with the Infoblox golang client, namely the addition of the nameserver to an authoritative zone or the restart of the DNS service. The client had to be slightly enhanced to do the missing operations by calling Infoblox REST API

@openshift-ci openshift-ci bot requested review from arjunrn and knobunc March 24, 2022 09:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@alebedev87 alebedev87 force-pushed the infoblox-e2e branch 3 times, most recently from 54ca33f to 7824551 Compare March 25, 2022 13:40
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@alebedev87 alebedev87 force-pushed the infoblox-e2e branch 2 times, most recently from a9be401 to f4c4e72 Compare March 28, 2022 20:46
@alebedev87
Copy link
Contributor Author

/assign @arjunrn

arjunrn
arjunrn reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@arjunrn arjunrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes but looks good overall.

test/e2e/util.go Outdated Show resolved Hide resolved
test/e2e/util.go Outdated Show resolved Hide resolved
test/e2e/util.go Outdated Show resolved Hide resolved
test/e2e/infoblox.go Show resolved Hide resolved
test/e2e/infoblox.go Show resolved Hide resolved
test/e2e/infoblox.go Show resolved Hide resolved
test/e2e/infoblox.go Outdated Show resolved Hide resolved
test/e2e/infoblox.go Show resolved Hide resolved
@alebedev87
Copy link
Contributor Author

/test all

Infoblox was moved to the long running QE account

@arjunrn
Copy link
Contributor

arjunrn commented Mar 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0c2b845 into openshift:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunrn arjunrn arjunrn left review comments

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@arjunrn arjunrn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alebedev87 @arjunrn @openshift-bot @openshift-merge-robot