NE-1362: External DNS should honor ingress type

[datianshi]

This PR allows end user to add source type as k8s Ingress (Now only OpenShift Route and K8s Service), which upstream already supported long time ago.

The use case can be.

Given User uses AWS Load Balancer Operator
And User uses External DNS Operator
When User uses K8s Ingress to configure AWS Application Load Balancer
Then The external dns operator creates DNS record based on the Ingress Address (In this case it is ALB CNAME)

And example configuration can be

---
apiVersion: externaldns.olm.openshift.io/v1alpha1
kind: ExternalDNS
metadata:
  name: sample-aws 
spec:
  domains:
  - filterType: Include   
    matchType: Exact   
    name: ${domain}
  provider:
    type: AWS
  source:  
    type: Ingress

[datianshi]

@alebedev87

[openshift-ci]

Hi @datianshi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Conan-Kudo]

This looks great to me. 👍🏾

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Conan-Kudo, datianshi
Once this PR has been reviewed and has the lgtm label, please assign alebedev87 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@datianshi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-infoblox-operator	d51a06c	link	true	/test e2e-infoblox-operator
ci/prow/verify	d51a06c	link	true	/test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Conan-Kudo]

/remove-lifecycle stale

[openshift-ci-robot]

@datianshi: This pull request references NE-1362 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

This PR allows end user to add source type as k8s Ingress (Now only OpenShift Route and K8s Service), which upstream already supported long time ago.

The use case can be.

Given User uses AWS Load Balancer Operator
And User uses External DNS Operator
When User uses K8s Ingress to configure AWS Application Load Balancer
Then The external dns operator creates DNS record based on the Ingress Address (In this case it is ALB CNAME)

And example configuration can be

---
apiVersion: externaldns.olm.openshift.io/v1alpha1
kind: ExternalDNS
metadata:
 name: sample-aws 
spec:
 domains:
 - filterType: Include   
   matchType: Exact   
   name: ${domain}
 provider:
   type: AWS
 source:  
   type: Ingress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[alebedev87]

/remove-lifecycle rotten

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[alebedev87]

/remove-lifecycle rotten