-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-32058: docs - add example of private dns zone for Azure provider #217
base: main
Are you sure you want to change the base?
Conversation
@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
260ad67
to
93050e1
Compare
93050e1
to
2d60480
Compare
Hence marking as verified |
/label qe-approved |
@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
@candita: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -37,10 +37,15 @@ openshift-console downloads downloads-openshift-console.apps. | |||
|
|||
6. Get the list of dns zones w.r.t your resource group to find the one which corresponds to the previously found route’s domain: | |||
```bash | |||
$ az network dns zone list --resource-group "${RESOURCE_GROUP}" | |||
$ ZONE_NAME=$(az network dns zone list -g "${RESOURCE_GROUP}" -o tsv --query '[0].name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a guarantee that there is one and only one dns zone?
@@ -37,10 +37,15 @@ openshift-console downloads downloads-openshift-console.apps. | |||
|
|||
6. Get the list of dns zones w.r.t your resource group to find the one which corresponds to the previously found route’s domain: | |||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a header similar to this, to distinguish this from the query for private dns zones.
I'm not sure what they should do if there are both public and private dns zones. Is it possible?
```bash | |
For public dns zones: | |
```bash |
8. Check the records created for `console` routes: | ||
8. Check the records created for the routes: | ||
```bash | ||
$ az network dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" | grep console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the removal of "console" from the instructions?
$ az network dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" | grep console | |
$ az network dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" |
@@ -59,7 +83,12 @@ spec: | |||
EOF | |||
``` | |||
|
|||
8. Check the records created for `console` routes: | |||
8. Check the records created for the routes: | |||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```bash | |
For public dns zones: | |
```bash |
```bash | ||
$ az network dns record-set list -g "${RESOURCE_GROUP}" -z test-azure.qe.azure.devcluster.openshift.com | grep console | ||
$ az network private-dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" | grep console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ az network private-dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" | grep console | |
$ az network private-dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" |
@alebedev87 in the description you mention a mistake that was found, but that command still exists with the old syntax:
Otherwise, just some minor clarifications needed. |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/remove-lifecycle stale |
az network dns record-set list
command, the correct syntax isaz network dns record-set a list