Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support externalTrafficPolicy: Local in LoadBalancerPublishingStrategy #3592

Closed
freedge opened this issue Feb 16, 2024 · 5 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@freedge
Copy link

freedge commented Feb 16, 2024

hypershift create cluster kubevirt renders spec:

  - service: APIServer
    servicePublishingStrategy:
      type: LoadBalancer

that ends up creating a service having

  externalTrafficPolicy: Cluster

It would be great if it could be Local instead, so that the traffic is routed to the right node
https://metallb.universe.tf/usage/#local-traffic-policy-1

@davidvossel
Copy link
Contributor

It would be great if it could be Local instead, so that the traffic is routed to the right node
https://metallb.universe.tf/usage/#local-traffic-policy-1

Yes, I see how that could benefit the Agent platform.

I'm unsure if the KubeVirt platform would benefit much from this though. In that case, the bulk of the api server traffic is going to come from the VMs acting as worker nodes which in most cases will result in internal traffic. Per the externalTrafficPolicy documentation, that internal traffic would default to Cluster even if we set it to Local.

Note that traffic sent to an External IP or LoadBalancer IP from within the cluster will always get "Cluster" semantics

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 16, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants