W/A for KubeVirt provider with RHCOS 9.2 #2373
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/e2e/create_cluster_test.go
Outdated
| @@ -41,6 +41,25 @@ func TestCreateCluster(t *testing.T) { | |||
|
|
|||
| hostedCluster := e2eutil.CreateCluster(t, ctx, client, &clusterOpts, globalOpts.Platform, globalOpts.ArtifactDir, globalOpts.ServiceAccountSigningKey) | |||
|
|
|||
| // Test W/A until https://github.com/coreos/fedora-coreos-tracker/issues/1126 is resolved | |||
There was a problem hiding this comment.
orenc1
force-pushed
the
workaround_for_rhcos_kubevirt_platform
branch
2 times, most recently
from
6fb35c3
to
dd49859
Compare
| @@ -86,7 +86,7 @@ func NewParams(hcp *hyperv1.HostedControlPlane, version string, images map[strin | |||
| WhereaboutsCNI: images["multus-whereabouts-ipam-cni"], | |||
| RouteOverrideCNI: images["multus-route-override-cni"], | |||
| MultusNetworkPolicy: images["multus-networkpolicy"], | |||
| OVN: images["ovn-kubernetes"], | |||
| OVN: images["ovn-kubernetes-rhel-9"], | |||
There was a problem hiding this comment.
this is just for CI to check it works, since currently we're testing with ocp 4.13 and there the release payload references ovn-kubernetes with the rhel-9 suffix
openshift-ci
bot
added
area/control-plane-operator
orenc1
force-pushed
the
workaround_for_rhcos_kubevirt_platform
branch
from
dd49859
to
7403836
Compare
Due to changes in RHCOS 9.2, the ignition config is not able to be fetched with the openstack provider. However, it works with kubevirt ignition provider. Adding a workaround that uses a modified RHCOS containerdisk that sets the kernel command line parameter of 'ignition.platform.id=kubevirt' instead of 'ignition.platform.id=openstack' Signed-off-by: Oren Cohen <ocohen@redhat.com>
orenc1
force-pushed
the
workaround_for_rhcos_kubevirt_platform
branch
from
7403836
to
e84ef13
Compare
| @@ -148,6 +148,8 @@ func WaitForNReadyNodes(t *testing.T, ctx context.Context, client crclient.Clien | |||
| switch platform { | |||
| case hyperv1.PowerVSPlatform: | |||
| waitTimeout = 60 * time.Minute | |||
| case hyperv1.KubevirtPlatform: | |||
| waitTimeout = 60 * time.Minute | |||
There was a problem hiding this comment.
looks like with RHCOS 9.2 the boot time is longer, 30 minutes are not enough for the VM to fully boot twice. extending to 60.
|
/test foo |
|
@qinqon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test kubevirt-e2e-kubevirt-aws-ovn |
|
@orenc1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closing in favor of #2399 , that blocks the metadata server by EgressFirewall rule. |
|
@orenc1: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Due to changes in RHCOS 9.2, the ignition config is not able to be fetched with the openstack provider. However, it works with kubevirt ignition provider. Adding a workaround that uses a modified RHCOS containerdisk that sets the kernel command line parameter of
ignition.platform.id=kubevirtinstead ofignition.platform.id=openstackThis is needed until coreos/fedora-coreos-tracker#1126 is resolved and we'll have our kubevirt artifact shipped with RHCOS.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist