Update controller-runtime to 0.10.1 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates controller-runtime (and with it the k8s.io/ dependencies) to 0.10.1. The main motivation is that I want to start collecting clientsside metrics, however there is currently `rest_client_request_latency_seconds` which includes the full request URL and thus has a huge cardinality. It got removed in the 0.10 release of controller-runtime.
alvaroaleman
force-pushed
the
update-cr
branch
from
93356b9
to
dd8192d
Compare
|
Seems unrelated: /retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
chaodaiG
added a commit
to chaodaiG/test-infra
that referenced
this pull request
Dec 9, 2021
Same reason as openshift/hypershift#521, removing flooding rest_client_request_latency_seconds from prometheus metrics
chaodaiG
added a commit
to chaodaiG/test-infra
that referenced
this pull request
Dec 9, 2021
Same reason as openshift/hypershift#521, removing flooding rest_client_request_latency_seconds from prometheus metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates controller-runtime (and with it the k8s.io/ dependencies)
to 0.10.1. The main motivation is that I want to start collecting
clientsside metrics, however there is currently
rest_client_request_latency_secondswhich includes the full request URL and thus has a huge cardinality. It
got removed in the 0.10 release of controller-runtime.
For reference, the c-r PR that removes it: kubernetes-sigs/controller-runtime#1587