-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907924: enable madvdontneed for golang #61
Bug 1907924: enable madvdontneed for golang #61
Conversation
@rphillips: This pull request references Bugzilla bug 1907924, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rphillips: This pull request references Bugzilla bug 1907924, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e2e-aws-upgrade: /test e2e-aws-upgrade |
/retest |
/uncc |
/retest |
Can't test in PR unfortunately (base doesn't propogate) so YOLO /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rphillips: All pull requests linked via external trackers have merged: Bugzilla bug 1907924 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@tnozicka: new pull request created: #75 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Golang 1.12 changed to use MADV_FREE. MADV_FREE is somewhat faster than MADV_DONTNEED; however, the kernel will not try and reclaim memory in golang processes until the system is memory constrained. Cloud servers can potentially page out executable caches, which can cause IOPS throttles. Since golang 1.16 will be changing the default to MADV_DONTNEED, we are going to enable the flag by default.
This patch is 1 of 2. We need a separate patch in MCO to enable the system daemons (Kubelet and Crio).
golang/go#42330