[release-4.16] OCPBUGS-38021: Integration of the OpenStack CRs into the insights-operator #974
Conversation
Control Plan of the Red Hat OpenStack starting from the version 18
(RHOSO 18) will be deployed using OpenShift operators as a set of
OpenShift applications.
Compute nodes will be deployed still as RHEL nodes and will be outside
of the OpenShift cluster but all will be mangaged by the
Dataplane-operator and only interface for OpenStack operators will be
though the CRs:
- OpenStackControlPlane CR for the control plane,
- OpenStackDataplaneNodeSet and OpenStackDataplaneDeployment CRs for the
compute nodes.
This patch adds OpenStackControlPlane CR to the insights-operator so that
whole configuration of the OpenStack control plane may be gathered by the
insights-operator and send to analysis to the Insights server.
Co-Authored-By: Yatin Karel <ykarel@redhat.com>
Conflicts:
docs/gathered-data.md
pkg/gatherers/clusterconfig/clusterconfig_gatherer.go
Related: #OSPRH-5904
(cherry picked from commit 999cbf5)
Some fields in the collected OpenStackControlPlane CRs should be anonymized. This is for example field 'options' from the 'dns' service spec. Related: #OSPRH-5904 (cherry picked from commit d725c1f)
(cherry picked from commit 1573f08)
For now it will drop only 'metadata/annotations/kubectl.kubernetes.io/last-applied-configuration' but other fields can be added to that list too. (cherry picked from commit c697f3d)
Control Plan of the Red Hat OpenStack starting from the version 18 (RHOSO 18) will be deployed using OpenShift operators as a set of OpenShift applications. Compute nodes will be deployed still as RHEL nodes and will be outside of the OpenShift cluster but all will be mangaged by the Dataplane-operator and only interface for OpenStack operators will be though the CRs: - OpenStackControlPlane CR for the control plane, - OpenStackDataplaneNodeSet and OpenStackDataplaneDeployment CRs for the compute nodes. This patch adds OpenStackDataplaneNodeSet CR to the insights-operator so that whole configuration of the OpenStack control plane may be gathered by the insights-operator and send to analysis to the Insights server. Co-Authored-By: Yatin Karel <ykarel@redhat.com> Related: #OSPRH-5904 (cherry picked from commit 809ea80)
Control Plan of the Red Hat OpenStack starting from the version 18 (RHOSO 18) will be deployed using OpenShift operators as a set of OpenShift applications. Compute nodes will be deployed still as RHEL nodes and will be outside of the OpenShift cluster but all will be mangaged by the Dataplane-operator and only interface for OpenStack operators will be though the CRs: - OpenStackControlPlane CR for the control plane, - OpenStackDataplaneNodeSet and OpenStackDataplaneDeployment CRs for the compute nodes. This patch adds OpenStackDataplaneDeployment CR to the insights-operator so that whole configuration of the OpenStack control plane may be gathered by the insights-operator and send to analysis to the Insights server. Co-Authored-By: Yatin Karel <ykarel@redhat.com> Related: #OSPRH-5904 (cherry picked from commit 52659ff)
(cherry picked from commit 933ac23)
(cherry picked from commit 5a82b6b)
Related: #OSPRH-5904 (cherry picked from commit c6feae6)
Red Hat's openstack-operator in addition to the OpenStackControlPlane and OpenStackDataPlane CRs uses also additonal CR 'openstackversions' which reports version of the openstack(s) deployed in the OCP cluster. This patch adds support for gathering also this CRs from the cluster if they exists. Related: #OSPRH-5904 (cherry picked from commit d0d5cc7)
slawqo
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@slawqo: This pull request references OSPRH-5904 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.z" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@slawqo How far back do you want to backport this plese? I didn't know (or forget) that you wanted to backport it. I am afraid that you will need an OCPBUGS JIRA to backport. |
We would like to have it in 4.16 release as this one is our target for RHOSO 18.0 GA release. I will check today this project on Jira and will open issue there. |
|
/test e2e-gcp-ovn-techpreview |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slawqo, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
tremes
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@slawqo: This pull request references Jira Issue OCPBUGS-38021, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@slawqo: This pull request references Jira Issue OCPBUGS-38021, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tremes: This pull request references Jira Issue OCPBUGS-38021, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/test e2e-agnostic-upgrade |
|
/retest |
2 similar comments
|
A test fails:- Seems real issue and iiuc ccx-testlib version needs to be updated for 4.16, @tremes @BaiyangZhou can you check/clear this |
|
/test insights-operator-e2e-tests |
|
Test failures are not related to these changes. |
|
@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slawqo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 0c42c04
into
openshift:release-4.16
|
@slawqo: Jira Issue OCPBUGS-38021: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-38021 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-insights-operator |
Control Plan of the Red Hat OpenStack starting from the version 18 (RHOSO 18) will be deployed using OpenShift operators as a set of OpenShift applications. Compute nodes will be deployed still as RHEL nodes and will be outside of the OpenShift cluster but all will be mangaged by the Dataplane-operator and only interface for OpenStack operators will be though the CRs:
This PR adds those OpenStack CRs to the insights-operator so that whole configuration of the OpenStack control plane may be gathered by the insights-operator and send to analysis to the Insights server.
Categories
Sample Archive
Unit Tests
Privacy
Anonymization functions are added and used while collecting OpenStack CRs. Anonymized data:
Changelog
No
Breaking Changes
No
References
https://issues.redhat.com/browse/OSPRH-5904
Additional Info
To test what data are collected by the insights-operator with those changes, OpenStack has to be deployed on top of the OpenShift cluster. The easiest way to do this is to use CRC OpenShift and install_yamls tool. Please follow the guide to deploy OpenStack Control Plane and OpenStackDataPlane CRs