Skip to content

Commit

Permalink
data/aws/route53/variables: Drop unused external_vpc_id and extra_tags
Browse files Browse the repository at this point in the history
The last consumer of these variables were removed by 4360905
(modulus,steps: enable existing vpc, 2018-05-16,
coreos/tectonic-installer#3231) back when it was
tectonic_external_vpc_id.  Now all the route53 module creates are
aws_route53_record resources, and they don't support tags [1].

[1]: https://www.terraform.io/docs/providers/aws/r/route53_record.html
  • Loading branch information
wking committed Nov 15, 2018
1 parent 31567af commit d3e3042
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
2 changes: 0 additions & 2 deletions data/data/aws/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ module "dns" {
elb_alias_enabled = true
master_count = "${var.tectonic_master_count}"
private_zone_id = "${local.private_zone_id}"
external_vpc_id = "${module.vpc.vpc_id}"
extra_tags = "${var.tectonic_aws_extra_tags}"
private_endpoints = "${local.private_endpoints}"
public_endpoints = "${local.public_endpoints}"
}
Expand Down
16 changes: 0 additions & 16 deletions data/data/aws/route53/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ variable "worker_public_ips_enabled" {
default = true
}

variable "extra_tags" {
type = "map"
description = "Extra tags to be applied to created resources."
}

// AWS specific internal zone variables

variable "elb_alias_enabled" {
Expand All @@ -60,17 +55,6 @@ EOF
default = false
}

variable "external_vpc_id" {
type = "string"

description = <<EOF
ID of an existing VPC to launch nodes into.
If unset a new VPC is created.
Example: `vpc-123456`
EOF
}

variable "private_endpoints" {
description = <<EOF
If set to true, create private-facing ingress resources (ELB, A-records).
Expand Down

0 comments on commit d3e3042

Please sign in to comment.