Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Rename InstallConfig.Machines to InstallConfig.MachinePools #478

Closed
dgoodwin opened this issue Oct 17, 2018 · 4 comments
Closed

Proposal: Rename InstallConfig.Machines to InstallConfig.MachinePools #478

dgoodwin opened this issue Oct 17, 2018 · 4 comments

Comments

@dgoodwin
Copy link
Contributor

In the interest of locking down this spec as much as possible, it feels like we should not have a field named "Machines" contain something that is a MachinePool, when Machine is actually a type that exists in our system.
@wking
Copy link
Member

wking commented Oct 17, 2018

I preferred your suggestion here ;). Can we close this issue in favor of that one?

@dgoodwin
Copy link
Contributor Author

Yes I'd definitely be good with that. If so we will follow suit on our side in Hive.

@crawford
Copy link
Contributor

crawford commented Jan 4, 2019

Closing due to inactivity.

@openshift-ci-robot
Copy link
Contributor

@crawford: Closing this issue.

In response to this:

Closing due to inactivity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dgoodwin @wking @crawford @openshift-ci-robot