-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/data/bootstrap: add etcd metrics flags #1377
Conversation
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hexfusion If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hexfusion: The following test failed for commit 2017293, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cgwalters @runcom I am told you folks are master of chicken and egg with regards to depending on data from flags that do not exist yet. |
we made some dance for the containerruntime crd, I'm gonna re-follow that process and get back! |
@hexfusion: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
moved to alternative approach. /close |
@abhinavdahiya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the TLS file paths to bootstrap for metrics assets created in #1291.
Depends on openshift/machine-config-operator#517