hack/build: Pin to RHCOS 400.7.20190306.0 #1407
Conversation
openshift-ci-robot
added
approved
|
/approve |
|
Very short term this is OK but soon we will need a newer version to get authenticated pivots to work. |
This is the most recent RHCOS: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json | jq '{"latest": .builds[0], timestamp}' { "latest": "400.7.20190306.0", "timestamp": "2019-03-06T22:24:53Z" } I'd prefer to pull this from the release image: $ oc adm release info --pullspecs quay.io/openshift-release-dev/ocp-release:4.0.0-0.7 | grep machine-os-content machine-os-content quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181 $ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181 | grep version version=47.330 But [1] isn't green yet, so hard-coding here is a quick fix. Supported regions: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/400.7.20190306.0/meta.json | jq -r '.amis[] | .name' ap-northeast-1 ap-northeast-2 ap-south-1 ap-southeast-1 ap-southeast-2 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-west-3 sa-east-1 us-east-1 us-east-2 us-west-1 us-west-2 [1]: openshift#1286
wking
changed the title
|
/approve |
|
This LGTM but I am going to rebase #1402 on top and also add an environment variable to select the build so we can conveniently test new versions without rebuilding the installer. |
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| set -ex | |||
|
|
|||
| RHCOS_BUILD_NAME="${RHCOS_BUILD_NAME:-400.7.20190306.0}" | |||
There was a problem hiding this comment.
I don't have a problem with this but note that the version referenced isn't an official cut.
There was a problem hiding this comment.
I don't have a problem with this but note that the version referenced isn't an official cut.
I don't care what we pin to, just tell me what you want ;)
There was a problem hiding this comment.
This is fine. I just wanted to note that it wasn't an officially ID'd build for any specific cut.
There was a problem hiding this comment.
FWIW 400.7.20190312.0 now exists which includes a pivot update among other things. @cgwalters do you need that as part of the pin?
There was a problem hiding this comment.
My tentative vote here is to ship this as is now and start building "mental muscle memory" or SOP for bumping it immediately after, but it's not a really strong opinion.
|
/test e2e-aws-rhel8 |
|
|
?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, cgwalters, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
resource quota and replica set errors. Flakes? |
|
/retest Yeah we have a successful run with the same commit. |
Drop the HTTP stuff in favor of just the local asset or OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE. In order to make life convenient for folks using OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE, rhcos-bootimage.py takes a --platform argument (and, for AWS, a --region argument) and spits out the value you'd feed into OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE instead of updating the rhcos.json asset source. The codecs business works around the lack of byte-stream support in json.load before Python 3.6 [1]. Also uncomment all of the regions in pkg/types/aws/validation (unwinding that part of bd88157, hack/build: Pin to RHCOS 400.7.20190306.0, 2019-03-12, openshift#1407). Instead, perform the "can we find an AMI for that region?" check directly in pkg/asset/installconfig/aws when we're building a list of regions for the wizard prompt. With this change, bumping the rhcos.json asset (via the script) will automatically keep the wizard prompt's choices in sync with the published AMIs. [1]: https://docs.python.org/3/library/json.html#json.load
Uncomment all of the regions in pkg/types/aws/validation (unwinding that part of bd88157, hack/build: Pin to RHCOS 400.7.20190306.0, 2019-03-12, openshift#1407). Instead, perform the "can we find an AMI for that region?" check directly in pkg/asset/installconfig/aws when we're building a list of regions for the wizard prompt. With this change, bumping the rhcos.json asset (via hack/update-rhcos-bootimage.py) will automatically keep the wizard prompt's choices in sync with the published AMIs.
Uncomment all of the regions in pkg/types/aws/validation (unwinding that part of bd88157, hack/build: Pin to RHCOS 400.7.20190306.0, 2019-03-12, openshift#1407). Instead, perform the "can we find an AMI for that region?" check directly in pkg/asset/installconfig/aws when we're building a list of regions for the wizard prompt. With this change, bumping the rhcos.json asset (via hack/update-rhcos-bootimage.py) will automatically keep the wizard prompt's choices in sync with the published AMIs.
Uncomment all of the regions in pkg/types/aws/validation (unwinding that part of bd88157, hack/build: Pin to RHCOS 400.7.20190306.0, 2019-03-12, openshift#1407). Instead, perform the "can we find an AMI for that region?" check directly in pkg/asset/installconfig/aws when we're building a list of regions for the wizard prompt. With this change, bumping the rhcos.json asset (via hack/update-rhcos-bootimage.py) will automatically keep the wizard prompt's choices in sync with the published AMIs.
@smarterclayton pushed release:4.0.0-0.nightly-2019-03-04-234414 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.7. Extracting the associated RHCOS build:
I'd like to be pulling that version out of the release image at install-time (#1286), but that PR isn't green yet, so hard-coding here is a quick fix.
CC @abhinavdahiya, @cgwalters