-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifests: add cloudproviderconfig asset #1479
manifests: add cloudproviderconfig asset #1479
Conversation
This configuration file is used to configure the Kubernetes cloud provider integration when using the built-in cloud provider integration or the external cloud controller manager. The configmap containing cloud provider config must be in `openshift-config` namespace as required by openshift/api PR 245 [1] [1]: https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L28
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhinavdahiya: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hold until @gnufied and I have a chance to sync up this week. |
@derekwaynecarr I double and triple checked storage bits for vsphere and traditionally in openshift-ansible when we configure vsphere cloudprovider, naturally you specify a datastore too. But - it is not mandatory to have datastore specified in storageclass and storagelclass will simply default to datastore configured in current workspace. So, in a nutshell - we don't need anything beyond platform being set to |
fyi @rphillips |
@abhinavdahiya: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@sdodson: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This configuration file is used to configure the Kubernetes cloud provider integration
when using the built-in cloud provider integration or the external cloud controller manager.
The configmap containing cloud provider config must be in
openshift-config
namespace as required by openshift/api PR 245 1/cc @staebler @derekwaynecarr
This should help plumb the vsphere cloud provider config whenever that becomes ready.