Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: add cloudproviderconfig asset #1479

Closed

Conversation

abhinavdahiya
Copy link
Contributor

This configuration file is used to configure the Kubernetes cloud provider integration
when using the built-in cloud provider integration or the external cloud controller manager.

The configmap containing cloud provider config must be in openshift-config namespace as required by openshift/api PR 245 1

/cc @staebler @derekwaynecarr
This should help plumb the vsphere cloud provider config whenever that becomes ready.

This configuration file is used to configure the Kubernetes cloud provider integration
when using the built-in cloud provider integration or the external cloud controller manager.

The configmap containing cloud provider config must be in `openshift-config` namespace as required by openshift/api PR 245 [1]

[1]: https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L28
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 9c118a6 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekwaynecarr
Copy link
Member

Hold until @gnufied and I have a chance to sync up this week.

@gnufied
Copy link
Member

gnufied commented Apr 1, 2019

@derekwaynecarr I double and triple checked storage bits for vsphere and traditionally in openshift-ansible when we configure vsphere cloudprovider, naturally you specify a datastore too. But - it is not mandatory to have datastore specified in storageclass and storagelclass will simply default to datastore configured in current workspace.

So, in a nutshell - we don't need anything beyond platform being set to vSphere. After that, if controller-manager is configured correctly, everything should work as expected. I am sorry that, my earlier assumption about this was not entirely correct. but like I said - I am 100% certain now that, we aren't going to need anything for configuring default storageclass.

@sjenning
Copy link
Contributor

sjenning commented Apr 1, 2019

fyi @rphillips

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Apr 8, 2019

/close
rolled into #1516

@openshift-ci-robot
Copy link
Contributor

@sdodson: Closed this PR.

In response to this:

/close
rolled into #1516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants