Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] upi/vsphere: cumulative changes #1492

Closed
wants to merge 4 commits into from
Closed

[WIP] upi/vsphere: cumulative changes #1492

wants to merge 4 commits into from

Conversation

staebler
Copy link
Contributor

Cumulative changes from the following.
#1488
#1489
#1490
#1470

staebler and others added 4 commits March 28, 2019 16:42
Add DNS records for the control plane and compute hostnames so that
they are resolvable from within the cluster.
The bootstrap machine pulls ignition config from a publicly-accessible
url. The pull secret contains sensitive information that should not
be publicly accessible. These changes strip the pull secret out of the
ignition config posted publicly and instead includes it in the ignition
config set directly in the vm.
Static IP addresses are now working with rhcos.
- Creates a vm folder
- Virtual Machines are deployed into the folder created
- Updated README.md
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@openshift-ci-robot
Copy link
Contributor

@staebler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/tf-fmt 118ecb3 link /test tf-fmt
ci/prow/e2e-aws 118ecb3 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor Author

staebler commented Apr 2, 2019

Closed in favor of #1518.

@staebler staebler closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants