Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPI][vSphere]Pr1492 vmw network #1502

Closed
wants to merge 10 commits into from
Closed

[UPI][vSphere]Pr1492 vmw network #1502

wants to merge 10 commits into from

Conversation

dav1x
Copy link
Contributor

@dav1x dav1x commented Mar 29, 2019

  1. Add network module for adding static_ipaddresses.
  2. Changes as requested here:
    [upi][vsphere] applicable static IP changes #1480

staebler and others added 6 commits March 28, 2019 16:42
@staebler
upi/vsphere: add dns for control plane and compute hostnames
b0e5626 
Add DNS records for the control plane and compute hostnames so that
they are resolvable from within the cluster.
@staebler
upi/vsphere: put pull secret directly in vm ignition config
4e08b3b 
The bootstrap machine pulls ignition config from a publicly-accessible
url. The pull secret contains sensitive information that should not
be publicly accessible. These changes strip the pull secret out of the
ignition config posted publicly and instead includes it in the ignition
config set directly in the vm.
@staebler
upi/vsphere: use static ip addresses
bca44b5 
Static IP addresses are now working with rhcos.
@jcpowermac @staebler
[WIP] vSphere UPI - Use a folder for virtual machines
118ecb3 
- Creates a vm folder
- Virtual Machines are deployed into the folder created
- Updated README.md
@dav1x
adding only network module for managing IP addresses
4abfeae
@dav1x
mend
6aa8356
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dav1x
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: russellb

If they are not already assigned, you can assign the PR to them by writing /assign @russellb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dav1x dav1x changed the title Pr1492 vmw network [UPI][vSphere]Pr1492 vmw network Mar 29, 2019
This was referenced Mar 29, 2019
Closed
Closed
@openshift-ci-robot
Copy link
Contributor

@dav1x: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2019 •
edited
Loading

@dav1x: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/shellcheck 40ccf36 link /test shellcheck
ci/prow/yaml-lint 40ccf36 link /test yaml-lint
ci/prow/tf-lint 40ccf36 link /test tf-lint
ci/prow/tf-fmt 40ccf36 link /test tf-fmt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor

/close

These changes were merged in #1518.

@openshift-ci-robot
Copy link
Contributor

@staebler: Closed this PR.

In response to this:

/close

These changes were merged in #1518.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dav1x dav1x deleted the pr1492-vmw-network branch April 10, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@steveej steveej Awaiting requested review from steveej

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dav1x @openshift-ci-robot @staebler @jcpowermac