Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machines/libvirt: Drop volume paths #1628

Merged
merged 1 commit into from
May 31, 2019
Merged

machines/libvirt: Drop volume paths #1628

merged 1 commit into from
May 31, 2019

Conversation

zeenix
Copy link
Contributor

@zeenix zeenix commented Apr 16, 2019 •
edited
Loading

Volume should be identified by their names and their paths should be left to their container pools. This change is needed to allow for custom storage locations.

This is the needed update in Installer for the actual change in the libvirt actuator: openshift/cluster-api-provider-libvirt#144

Fixes #308.

@zeenix
libvirt: Drop volume paths
cfbf99c 
Volume should be identified by their names and their paths should be
left to their container pools. This change is needed to allow for custom
storage locations.

This is the needed update in Installer for the actual change in the
libvirt actuator: openshift/cluster-api-provider-libvirt#144
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2019
@zeenix zeenix mentioned this pull request Apr 16, 2019
Merged
@abhinavdahiya abhinavdahiya changed the title libvirt: Drop volume paths machines/libvirt: Drop volume paths Apr 16, 2019
@cgwalters
Copy link
Member

I tested this, and it
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@zeenix
Copy link
Contributor Author

zeenix commented Apr 17, 2019

@cgwalters Thanks. It shouldn't work with existing actuator btw so I'm guessing you tested with an override for the actuator including openshift/cluster-api-provider-libvirt#144 ?

@cgwalters
Copy link
Member

It shouldn't work with existing actuator btw

Upon some inspection, turns out I'd recently changed my installer dev flow and while I'd built the installer from your PR I hadn't actually moved it into my $PATH...sorry for the noise.

@praveenkumar
Copy link
Contributor

/test e2e-libvirt

@zeenix
Copy link
Contributor Author

zeenix commented Apr 23, 2019

@praveenkumar The test will fail until openshift/cluster-api-provider-libvirt#144 is merged. The change there is backwards compatible but not here so we need to handle that PR first.

@zeenix
Copy link
Contributor Author

zeenix commented Apr 25, 2019

/test e2e-libvirt

1 similar comment
@zeenix
Copy link
Contributor Author

zeenix commented May 2, 2019

/test e2e-libvirt

@zeenix
Copy link
Contributor Author

zeenix commented May 20, 2019

/retest

@zeenix zeenix mentioned this pull request May 21, 2019
Closed
@zeenix
Copy link
Contributor Author

zeenix commented May 21, 2019

/retest

@zeenix
Copy link
Contributor Author

zeenix commented May 21, 2019

/test e2e-libvirt

@praveenkumar
Copy link
Contributor

/retest

@zeenix
Copy link
Contributor Author

zeenix commented May 22, 2019

/test e2e-libvirt

1 similar comment
@zeenix
Copy link
Contributor Author

zeenix commented May 27, 2019

/test e2e-libvirt

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, zeenix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@praveenkumar
Copy link
Contributor

/approved

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e3ba84d into openshift:master May 31, 2019
@zeenix zeenix deleted the drop-volume-paths branch June 12, 2019 14:53
@zeenix zeenix mentioned this pull request Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@flaper87 flaper87 Awaiting requested review from flaper87

Assignees

@cgwalters cgwalters

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libvirt: can't create workers with non-default storage path
6 participants
@zeenix @cgwalters @praveenkumar @openshift-ci-robot @openshift-bot @openshift-merge-robot