tests/run: Use one Python invocation (no jq) for editing the config #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
|
retest this please |
|
Can we merge this after #162 (assuming the tests pass on this round)? |
Fine with me :) |
|
retest this please |
|
The tests on #162 are still giving me trouble. /lgtm |
That may be a real thing; I'll check in the morning. |
wking
force-pushed
the
smoke-test-one-python
branch
from
64ba786
to
d8f296c
Compare
|
/lgtm |
We've used the Python -> jq (-> jq) -> Python approach to editing the config file since this script landed in a2405e4 (run smoke tests with bash script, 2018-06-18, coreos/tectonic-installer#3284). But it's more efficient and almost equally compact to perform those edits directly in Python. This commit uses a here-document [1] to inject the Python script. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04
wking
force-pushed
the
smoke-test-one-python
branch
from
d8f296c
to
58bc279
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filed as #169. |
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 1, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 1, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 1, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 5, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 5, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 5, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 5, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Feb 12, 2019
Change machine-config-server port from 49500 -> 22623 to avoid conflict with local port and node port ranges. Closes machine-config-operator issue: openshift#166
EmilienM
pushed a commit
to shiftstack/installer
that referenced
this pull request
Dec 8, 2020
fix incorrect path description, in future it may corrupt scripting arch. Close openshift#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've used the Python ->
jq(->jq) -> Python approach to editing the config file since this script landed in a2405e4 (coreos/tectonic-installer#3284). But it's more efficient and almost equally compact to perform those edits directly in Python.This commit uses a here-document to inject the Python script.
Once this PR lands, I'll file follow-up work to add
expirationDatetoextraTags(like we have for the e2e-aws tests since openshift/release#1103).