asset/store: log asset creation #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users generally won't be interested in anything but WARN and above during normal operation.
It's a little more common to provide a response to a prompt on the same line.
This will help with logging in the near future.
openshift-ci-robot
added
approved
This makes it clear when and why a particular asset was created so it
should help with debugging. The output of this looks as follows:
INFO[0000] Fetching Bootstrap Ignition Config...
DEBU[0000] Generating dependencies of Bootstrap Ignition Config...
INFO[0000] Fetching Install Config...
DEBU[0000] Generating dependencies of Install Config...
INFO[0000] Fetching Cluster ID...
DEBU[0000] Generating Cluster ID...
INFO[0000] Fetching Email Address...
DEBU[0000] Generating Email Address...
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Dunno what the errors were. I see nothing worse than warnings in the yaml-lint output, and the tf-lint output is the enthusiastic: Maybe a Prow/GitHub flake of some sort. /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clear when and why a particular asset was created so it
should help with debugging. The output of this looks as follows: