Revert "pkg/ipnet: Add DeepCopy and DeepCopyInto for IPNet" #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06739c6, openshift#276. Devan's forking the config in Hive [1], so they no longer need us to support embedding in Kubernetes objects. [1]: openshift#256 (comment)
openshift-ci-robot
added
approved
wking
force-pushed
the
drop-deep-copy
branch
from
2589d69
to
ca6f619
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
should be fixed by openshift/release#1605. /retest |
wking
added a commit
to wking/hive
that referenced
this pull request
Dec 19, 2018
Catching up with openshift/installer@b2d6fa40 (validate: simplify CIDR validation, 2018-11-27, openshift/installer#711). We can't convert the v1alpha1 type to an *IPNet, because it doesn't have DeepCopyInto methods [1]: go vet ./pkg/... ./cmd/... ./contrib/... # github.com/openshift/hive/pkg/apis/hive/v1alpha1 pkg/apis/hive/v1alpha1/zz_generated.deepcopy.go:87:8: (*in).DeepCopyInto undefined (type *ipnet.IPNet has no field or method DeepCopyInto) We used to define those methods in the installer, but stopped in openshift/installer@ca6f6195 (Revert "pkg/ipnet: Add DeepCopy and DeepCopyInto for IPNet", 2018-09-20, openshift/installer#295). [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_hive/144/pull-ci-openshift-hive-master-unit/253/build-log.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 06739c6, #276.
Devan's forking the config in Hive, so they no longer need us to support embedding in Kubernetes objects.