OpenStack: Temporary disable image import #3394
Conversation
Looks like image import is not configured well on our testing cloud, which leads to the uploading error. We have to temporary disable image import in the installer until the cloud is fixed.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@Fedosin: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick fcos |
|
@vrutkovs: once the present PR merges, I will cherry-pick it on top of fcos in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-openstack |
|
/lgtm |
|
@vrutkovs: new pull request created: #3397 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // FIXME(mfedosin): We have to temporary disable image import, because it looks | ||
| // like there are problems on the server side. | ||
| // Revert this patch when the problems are fixed. | ||
| useImageImport := false | ||
| // useImageImport, err := isImageImportSupported(cloud) | ||
| // if err != nil { | ||
| // return err | ||
| // } |
There was a problem hiding this comment.
i do not think we should be tracking this in code as comments. I think we should have opened a
- github issue or bz detailing the issue
- switch to import false with comment linking to the issue.
There was a problem hiding this comment.
@abhinavdahiya You're absolutely right. Sorry I was pushing for this to merge ASAP as it was preventing us from running the CI on an alternate cloud provider.
I'll submit a patch that links to okd-project/okd#122
Looks like image import is not configured well on our testing cloud, which leads to the uploading error.
We have to temporary disable image import in the installer until the cloud is fixed.