Bug 1843314: baremetal: bump ironic timeout to 3600 seconds #3721
Conversation
|
/hold Hold pending feedback from others |
openshift-ci-robot
added
the
do-not-merge/hold
terraform-provider-ironic recently changed the approach it uses for timeouts from an estimate based on number of attempts, to using a go routine in a context. The logic it used to estimate was off by more than a factor of two. That means the current 1500 second timeout was actually more than 3000. This commit restores the previously unintended behavior as now explicitly set. The latest RHCOS images are around 800 MB in size. At 256kB/s, this would be 3,125 seconds to download. We also have to allow time for the bootstrap VM itself to boot, which we could alot 5 minutes for, totaling 3,425 seconds. I round it up to 3600 just for the even number. This timeout is unfortunate but I think is required for users who download the images directly from the internet and not a local cache. Ideally we would be able to monitor in real time what the machine-os-downloader container is doing, and fail earlier if an error it encountered was fatal.
|
/lgtm |
|
/label platform/baremetal |
stbenjam
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@stbenjam: This pull request references Bugzilla bug 1843314, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@stbenjam: This pull request references Bugzilla bug 1843314, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@stbenjam: This pull request references Bugzilla bug 1843314, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
|
@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-metal-ipi |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: All pull requests linked via external trackers have merged: openshift/installer#3721. Bugzilla bug 1843314 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: new pull request created: #3739 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
terraform-provider-ironic recently changed the approach it uses for
timeouts from an estimate based on number of attempts, to using a
go routine in a context. The logic it used to estimate was off by more
than a factor of two. That means the current 1500 second timeout was
actually more than 3000.
This commit restores the previously unintended behavior as now
explicitly set. The latest RHCOS images are around 800 MB in size. At
256kB/s, this would be 3,125 seconds to download. We also have to allow
time for the bootstrap VM itself to boot, which we could alot 5 minutes
for, totaling 3,425 seconds. I round it up to 3600 just for the even
number.
This timeout is unfortunate but I think is required for users who
download the images directly from the internet and not a local cache.
Ideally we would be able to monitor in real time what the
machine-os-downloader container is doing, and fail earlier if an error
it encountered was fatal. The problem is it happens while the
installer is running terraform, so I'm not sure the plans in
openshift/enhancements#328 would even
be able to cover this case.