Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibmcloud] Update os name to correct value #5860

Conversation

jeffnowicki
Copy link
Contributor

@jeffnowicki jeffnowicki commented May 2, 2022

A custom image is used for VSI provisioning. We were unable to to set the operating system name correctly until additional support was added to VPC IaaS.

That support has been added and is available in all supported regions.

This PR will set the os name value to: red-coreos-stable-amd64 (previously set to: fedora-coreos-stable-amd64").

@jeffnowicki
Copy link
Contributor Author

/assign @jstuever

@patrickdillon
Copy link
Contributor

This looks fine but would you be able to update the commit message according to https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format

A short description of why & what for the change should be sufficient.

ibmcloud vpc support added so os name could be set to
the correct value, previously set to fedora-coreos-stable-amd64
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 764f0ab into openshift:master May 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

@jeffnowicki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 9f339a3 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cjschaef added a commit to cjschaef/installer that referenced this pull request Jul 19, 2022
Update the image tag for the VSI's in IBM Cloud to be RHCOS rather
than Fedora CoreOS, now that IBM Cloud provides proper support for
the RHCOS image tag.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082604
Related: openshift#5869
Related: openshift#5860
TrilokGeer pushed a commit to TrilokGeer/installer that referenced this pull request Sep 14, 2022
Update the image tag for the VSI's in IBM Cloud to be RHCOS rather
than Fedora CoreOS, now that IBM Cloud provides proper support for
the RHCOS image tag.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082604
Related: openshift#5869
Related: openshift#5860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants