-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ibmcloud] Update os name to correct value #5860
[ibmcloud] Update os name to correct value #5860
Conversation
/assign @jstuever |
This looks fine but would you be able to update the commit message according to https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format A short description of why & what for the change should be sufficient. |
ibmcloud vpc support added so os name could be set to the correct value, previously set to fedora-coreos-stable-amd64
2f99d2f
to
9f339a3
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@jeffnowicki: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update the image tag for the VSI's in IBM Cloud to be RHCOS rather than Fedora CoreOS, now that IBM Cloud provides proper support for the RHCOS image tag. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082604 Related: openshift#5869 Related: openshift#5860
Update the image tag for the VSI's in IBM Cloud to be RHCOS rather than Fedora CoreOS, now that IBM Cloud provides proper support for the RHCOS image tag. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2082604 Related: openshift#5869 Related: openshift#5860
A custom image is used for VSI provisioning. We were unable to to set the operating system name correctly until additional support was added to VPC IaaS.
That support has been added and is available in all supported regions.
This PR will set the os name value to:
red-coreos-stable-amd64
(previously set to:fedora-coreos-stable-amd64"
).