Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go version check to build script. #621

Merged
merged 3 commits into from
Dec 7, 2018
Merged

add go version check to build script. #621

merged 3 commits into from
Dec 7, 2018

Conversation

droslean
Copy link
Member

@droslean droslean commented Nov 6, 2018 •
edited
Loading

Adds a version check before continuing the build process.
related to #579
closes #619

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2018
@droslean
Copy link
Member Author

droslean commented Nov 6, 2018

/assign @wking

@droslean droslean mentioned this pull request Nov 7, 2018
Closed
@wking wking mentioned this pull request Nov 16, 2018
Closed
@akostadinov akostadinov mentioned this pull request Nov 26, 2018
Closed
@akostadinov
Copy link

This is useful because build process would fail with a more understandable error message. Presently on needs to search about the failure message to figure out that go version is the issue.

@akostadinov
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2018
akostadinov
akostadinov reviewed Nov 26, 2018
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2018
@droslean droslean force-pushed the go-version-check branch 3 times, most recently from 8e4a725 to 47386f8 Compare December 4, 2018 10:49
@droslean
Copy link
Member Author

droslean commented Dec 4, 2018

without using gawk I can't satisfy the shellcheck. In this case, I guess there is a bug in shellcheck itself. Otherwise, I have to do some really ugly hacks in order to pass the shellcheck.

Bug opened koalaman/shellcheck#1408

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2018
akostadinov
akostadinov reviewed Dec 4, 2018
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
@droslean
Copy link
Member Author

droslean commented Dec 6, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2018
@akostadinov
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2018
@droslean
Copy link
Member Author

droslean commented Dec 6, 2018

/test e2e-aws

3 similar comments
@droslean
Copy link
Member Author

droslean commented Dec 6, 2018

/test e2e-aws

@droslean
Copy link
Member Author

droslean commented Dec 6, 2018

/test e2e-aws

@droslean
Copy link
Member Author

droslean commented Dec 6, 2018

/test e2e-aws

crawford
crawford reviewed Dec 6, 2018
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
@crawford
Copy link
Contributor

crawford commented Dec 6, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@droslean
Copy link
Member Author

droslean commented Dec 7, 2018

/test e2e-aws

@akostadinov
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akostadinov, crawford, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 015ac0f into openshift:master Dec 7, 2018
@droslean droslean deleted the go-version-check branch December 7, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akostadinov akostadinov akostadinov left review comments

@crawford crawford crawford left review comments

@staebler staebler Awaiting requested review from staebler

@wking wking Awaiting requested review from wking

Assignees

@wking wking

@akostadinov akostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build from master !! ??
6 participants
@droslean @akostadinov @crawford @openshift-ci-robot @wking @openshift-merge-robot