AGENT-326: Fix releaseImage mirror handling with unit test #6275
Conversation
Based on openshift#6272, this fixes the mirror generation to handle release images that include the sha256 checksum, e.g: quay.io/openshift-release-dev/ocp-release@sha256:300bce8246cf880e792e106607925de0a404484637627edf5f517375517d54a4
|
/cc @celebdor |
|
/retest |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // include the tag with the build release image | ||
| if len(source) == 4 { | ||
| // Has Sha256 | ||
| releaseImageMirror = fmt.Sprintf("%s%s:%s", config.Mirror, source[2], source[3]) |
There was a problem hiding this comment.
nit: this could be slightly simplified to: releaseImageMirror = fmt.Sprintf("%s@sha256:%s", config.Mirror, source[3])
|
/lgtm |
| } else if len(source) == 3 { | ||
| releaseImageMirror = fmt.Sprintf("%s:%s", config.Mirror, source[2]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Pre-existing issue, but it's a bit surprising that we don't return or break here, so we're always choosing the last matching mirror on the list.
zaneb
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Based on #6272, this fixes the mirror generation to handle release images that include the sha256 checksum, e.g:
quay.io/openshift-release-dev/ocp- release@sha256:300bce8246cf880e792e106607925de0a404484637627edf5f517375517d54a4