Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-6015: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks #6783

Merged
merged 2 commits into from
Jan 19, 2023
Merged

[release-4.12] OCPBUGS-6015: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks #6783

merged 2 commits into from
Jan 19, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #6469

/assign rvanderp3

@rvanderp3
OCPBUGS-881: fail to create install-config.yaml as apiVIP and ingress…
e7947f9 
…VIP are not in machine networks

validate VIPs are in machineNetwork in survey
@rvanderp3
addressing linting issues
14ff33e
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-881 has been cloned as Jira Issue OCPBUGS-6015. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-6015: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks

In response to this:

This is an automated cherry-pick of #6469

/assign rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-881: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks [release-4.12] OCPBUGS-6015: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks Jan 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-6015: fail to create install-config.yaml as apiVIP and ingress VIP are not in machine networks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-6015, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-881 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-881 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #6469

/assign rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gpei, mmartinv and rvanderp3 January 18, 2023 22:41
@gpei
Copy link
Contributor

gpei commented Jan 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 19, 2023
@gpei
Copy link
Contributor

gpei commented Jan 19, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-6015, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-881 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-881 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @WenXinWei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from WenXinWei January 19, 2023 00:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 14ff33e link false /test e2e-crc
ci/prow/okd-scos-e2e-aws-upgrade 14ff33e link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-ovirt-sdn 14ff33e link false /test e2e-ovirt-sdn
ci/prow/e2e-nutanix-ovn 14ff33e link false /test e2e-nutanix-ovn
ci/prow/okd-scos-e2e-aws-ovn 14ff33e link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade 14ff33e link false /test e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade 14ff33e link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-disruptive 14ff33e link false /test e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Copy link
Contributor

thunderboltsid commented Jan 19, 2023 •
edited
Loading

@rvanderp3 this is also impacting Nutanix IPI installs. The workaround we are recommending at the moment is to use dummy VIP values (10.0.01 and 10.0.02) when filling survey and them modifying generated install-config until a 4.12 release with this backported change is available. Hoping we can get this merged soon.

@rvanderp3
Copy link
Contributor

@rvanderp3 this is also impacting Nutanix IPI installs. The workaround we are recommending at the moment is to use dummy VIP values (10.0.01 and 10.0.02) when filling survey and them modifying generated install-config until a 4.12 release with this backported change is available. Hoping we can get this merged soon.

right, i updated the validation for nutanix in this PR as well.

@patrickdillon
Copy link
Contributor

/label backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 19, 2023
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit e33d9bd into openshift:release-4.12 Jan 19, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6015 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #6469

/assign rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fortinj66 fortinj66 mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpei gpei Awaiting requested review from gpei

@mmartinv mmartinv Awaiting requested review from mmartinv

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@WenXinWei WenXinWei Awaiting requested review from WenXinWei

Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @gpei @thunderboltsid @rvanderp3 @patrickdillon @openshift-merge-robot