asset/installconfig: improve validation of user inputs #711
Commits on Dec 15, 2018
-
validate: improve base domain validation
Use kubernetes validation of rfc-1123 sub-domains, with the addition that the base domain can end with a dot. This change removes the ability to use uppercase letters in the base domain. https://jira.coreos.com/browse/CORS-850
-
validate: improve cluster name validation
Use kubernetes validation of rfc-1123 sub-domains. This change removes the restriction that each label in the cluster name is at most 63 characters long. https://jira.coreos.com/browse/CORS-850
-
validate: improve image pull secret validation
Validate that (1) there is an "auths" field, (2) the "auths" value has fields, and (3) each field in the "auth" value has an "auth" or a "credsStore" field. https://jira.coreos.com/browse/CORS-850
-
validate: improve ssh public key validation
Use ParseAuthorizedKey from golang.org/x/crypto/ssh to validate that the provided ssh key can be parsed. https://jira.coreos.com/browse/CORS-850
-
vendor: golang.org/x/crypto ssh sub-package
The validation functions use golang.org/x/crypto/ssh to validate the ssh key provided. https://jira.coreos.com/browse/CORS-850
-
asset/installconfig: move uri validation to validation package
Move the uri validation from pkg/asset/installconfig/libvirt to pkg/validation for consistency with other validation functions. https://jira.coreos.com/browse/CORS-850
-
validate: simplify CIDR validation
Much of the code that made of the CIDR validation was there to give a custom description of what made the CIDR provided invalid. This has been removed in favor of using the error returned by the golang library's ParseCIDR function. Additionally, the code to determine whether two CIDRs overlap was unnecessary complex because it did not take advantage of the fact that CIDRs only overlap if one is a subset of the other. https://jira.coreos.com/browse/CORS-850
-
asset/installconfig: validate InstallConfig loaded from file
When an InstallConfig asset is loaded from an on-disk file, validate that the fields of the InstallConfig have appropriate values. This uses all the same validations that are down on the user-provided assets upon which the InstalConfig asset depends as well as addition validations on other fields. #711
-
asset/installconfig: remove emailaddress asset
The emailaddress asset is no longer used as of commit e7aaedb.
-
validate: remove unused functions
Remove validation functions that are no longer being used. https://jira.coreos.com/browse/CORS-850
-
-
-
vendor: add github.com/golang/mock/gomock
Add gomock to use to mock asset.FileFetcher in unit tests that load assets. https://jira.coreos.com/browse/CORS-850
-
asset/installconfig: validate openstack platform values in install-co…
…nfig.yml Move the fetching of openstack platform values to types/openstack/validation so that it can be used to validate values in the install-config.yml as well. https://jira.coreos.com/browse/CORS-888
-
