Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: AGENT-601: support for okd-scos #7112

Closed
wants to merge 1 commit into from

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Apr 20, 2023

This is PoC to explore the required changes to support okd-scos for agent-based installer.

Notes:

  • The scos.json is identical to the previous fcos.json except for x86_64 metal iso
  • The extraction of the base ISO from machine-os-images has been excluded because not yet available for scos, so using a direct download (that would be required for disconnected installs)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

@andfasano: This pull request references AGENT-601 which is a valid jira issue.

In response to this:

This is PoC to explore the required changes to support okd-scos for agent-based installer.

The scos.json is identical to the previous fcos.json except for x86_64 metal iso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

/draft

@andfasano andfasano changed the title AGENT-601: support for okd-scos WIP: AGENT-601: support for okd-scos Apr 20, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2023

@andfasano: This pull request references AGENT-601 which is a valid jira issue.

In response to this:

This is PoC to explore the required changes to support okd-scos for agent-based installer.

Notes:

  • The scos.json is identical to the previous fcos.json except for x86_64 metal iso
  • The extraction of the base ISO from machine-os-images has been excluded because not yet available for scos, so using a direct download (that would be required for disconnected installs)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment on lines 23 to +24
fcosTAG = "okd"
scosTAG = "scos"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fcosTAG = "okd"
scosTAG = "scos"
okdTag = "okd"
fcosTAG = "fcos"
scosTAG = "scos"

the okd and fcos Go build tags used elsewhere in the installer are synonymous. Let's add an okdTAG here and treat it like fcosTAG.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 4, 2023
@LorbusChris
Copy link
Member

We're not going to add an scos.json that references SCOS bootimages in the near term, as we don't currently have any distribution channels for these boot images.
We might revisit this once:

Voting to close this PR.

@andfasano
Copy link
Contributor Author

We're not going to add an scos.json that references SCOS bootimages in the near term, as we don't currently have any distribution channels for these boot images. We might revisit this once:

* tooling to derive bootimages from ostree containers has been built out ([Create tooling to take a FCOS-derived container and generate bootable images from it coreos/fedora-coreos-tracker#1151](https://github.com/coreos/fedora-coreos-tracker/issues/1151), https://gitlab.com/CentOS/cloud/sagano-builder)

* bootimages are distributed as OCI artifacts through OCI registries

Voting to close this PR.

Not a problem, as this PR was meant just to explore the ABI gaps to support OKD scos. Is there any documentation available about the current distribution?

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade eda97a6 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-sno-ipv6 eda97a6 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-ha-dualstack eda97a6 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-aws-ovn eda97a6 link true /test e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn eda97a6 link false /test okd-e2e-aws-ovn
ci/prow/altinfra-images eda97a6 link true /test altinfra-images
ci/prow/terraform-images eda97a6 link true /test terraform-images
ci/prow/terraform-verify-vendor eda97a6 link true /test terraform-verify-vendor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants