Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootkube.sh: drop final mention of machine-os-content #7636

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 26, 2023

That variable isn't used anywhere. The last reference was removed as part of 33a74c7 ("bootkube: Drop cruft in MCO bootstrap") a while ago.

Part of trying to get rid of machine-os-content:

https://issues.redhat.com/browse/MCO-392

That variable isn't used anywhere. The last reference was removed as
part of 33a74c7 ("bootkube: Drop cruft in MCO bootstrap") a while
ago.

Part of trying to get rid of `machine-os-content`:

https://issues.redhat.com/browse/MCO-392
@LorbusChris
Copy link
Member

Thanks for filing this! I hadn't realized this isn't used anymore.
/lgtm
/test okd-scos-e2e-aws-ovn

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@andfasano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 508c10f into openshift:master Oct 27, 2023
@LorbusChris
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot

@LorbusChris: new pull request created: #7669

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants