Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Add flavor selection support. #788

Merged
merged 1 commit into from
Dec 24, 2018
Merged

openstack: Add flavor selection support. #788

merged 1 commit into from
Dec 24, 2018

Conversation

russellb
Copy link
Member

@russellb russellb commented Dec 5, 2018

OpenStack flavors (analogous to AWS instance types) are not
standardized, so we can't pick a default that works across all
environments. This patch adds this as one of the items that must be
specified.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2018
@russellb russellb mentioned this pull request Dec 5, 2018
Merged
@russellb
Copy link
Member Author

/retest

trown
trown reviewed Dec 12, 2018
View reviewed changes
Copy link

@trown trown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this with vexxhost (which doesnt have m1.medium flavor), and it worked great.

crawford
crawford reviewed Dec 12, 2018
View reviewed changes
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to add more prompts. OpenStack already has a few too many. We should instead default and let users override that in their install-config. AWS, for example, doesn't have a prompt for changing the instance type.

pkg/asset/installconfig/openstack/openstack.go Outdated
return nil
}),
},
"OPENSHIFT_INSTALL_OPENSTACK_COMPUTE_FLAVOR",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to conflict with #861. We are removing environment variables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can fix this up once that lands.

As for this being a prompt or not, the difference between AWS and OpenStack is whether it's possible to pick a sane default. With AWS, we know what the flavors are, but for OpenStack, it's not standardized at all.

@russellb
Copy link
Member Author

Rebased on master.

As noted in my last comment, I still think this is required since it's a case where there's no obvious default since flavors (instance types) are not standardized across clouds. The best alternative I can think of is to write some logic to examine what flavors exist and try to pick one that looks like it has enough resources (CPU/RAM/disk). That doesn't seem great either, though.

@crawford
Copy link
Contributor

Hmmmm, I guess this is the best approach then.

@flaper87
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2018
@flaper87
Copy link
Contributor

oh, it's got a conflict 😢

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2018
@russellb
Copy link
Member Author

@flaper87 rebased

@russellb
Copy link
Member Author

oops, something is wrong with the new test code ...

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2018
@russellb
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2018
@russellb
openstack: Add flavor selection support.
aa4fd89 
OpenStack flavors (analogous to AWS instance types) are not
standardized, so we can't pick a default that works across all
environments.  This patch adds this as one of the items that must be
specified.
@russellb
Copy link
Member Author

/retest

@flaper87
Copy link
Contributor

/test e2e-aws

@flaper87
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5e7b36d into openshift:master Dec 24, 2018
@wking wking mentioned this pull request Jan 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford crawford left review comments

@trown trown trown left review comments

@flaper87 flaper87 Awaiting requested review from flaper87

@hardys hardys Awaiting requested review from hardys

Assignees

@flaper87 flaper87

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@russellb @crawford @flaper87 @openshift-bot @openshift-ci-robot @trown @openshift-merge-robot