OCPBUGS-35430: Support CAPI provider custom timeouts #8568
Conversation
|
/test altinfra-e2e-powervs-capi-ovn |
|
/test altinfra-e2e-aws-ovn |
|
/lgtm Seems like a good idea. |
hamzy
force-pushed
the
support-capi-provider-timeouts
branch
from
aa224a2
to
8fb5bda
Compare
openshift-merge-robot
added
the
needs-rebase
|
NOTE: I am only changing the commit message. |
Query the CAPI provider for the timeouts needed during provisioning. This is optional to support. The current default of 15 minutes is sufficient for normal CAPI installations. However, given how the current PowerVS CAPI provider waits for some resources to be created before creating the load balancers, it is possible that the LBs will not create before the 15 minute timeout. An issue was created to track this [1]. [1] kubernetes-sigs/cluster-api-provider-ibmcloud#1837
hamzy
force-pushed
the
support-capi-provider-timeouts
branch
from
8fb5bda
to
a849adc
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
hamzy
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@hamzy: This pull request references Jira Issue OCPBUGS-35430, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.16 |
1 similar comment
|
/cherry-pick release-4.16 |
|
@hamzy: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@hamzy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
@hamzy: Jira Issue OCPBUGS-35430: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35430 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hamzy: new pull request created: #8624 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Query the CAPI provider for the timeouts needed during provisioning. This is optional to support.
The current default of 15 minutes is sufficient for normal CAPI installations. However, given how the current PowerVS CAPI provider waits for some resources to be created before creating the load balancers, it is possible that the LBs will not create before the 15 minute timeout. An issue was created to track this [1].
[1] kubernetes-sigs/cluster-api-provider-ibmcloud#1837