Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3562: azure: Setting experimental MachinePool featuregate to false #8637

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Jun 20, 2024

This feature gate was set to a default of true upstream via kubernetes-sigs/cluster-api#10141. Setting it to false locally. Will enable this feature gate at a later time.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2024

@sadasu: This pull request references CORS-3562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

This feature gate was set to a default of true upstream via kubernetes-sigs/cluster-api#10141. Setting it to false locally. Will enable this feature gate at a later time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor

r4f4 commented Jun 20, 2024

/test altinfra-e2e-azure-capi-ovn

pkg/clusterapi/system.go Outdated Show resolved Hide resolved
This feature gate was set to a default of true upstream.
Setting it to false locally.
@sadasu sadasu force-pushed the azure-disable-machinepool-feature-gate branch from 71c8069 to 5ea59f6 Compare June 20, 2024 17:31
@sadasu
Copy link
Contributor Author

sadasu commented Jun 20, 2024

/test altinfra-e2e-azure-capi-ovn

@sadasu
Copy link
Contributor Author

sadasu commented Jun 20, 2024

/cc @jhixson74

@openshift-ci openshift-ci bot requested a review from jhixson74 June 20, 2024 18:02
@r4f4
Copy link
Contributor

r4f4 commented Jun 20, 2024

Now I see in the logs:

time="2024-06-20T19:33:16Z" level=info msg="Running process: azure infrastructure provider with args [-v=2 --diagnostics-address=0 --health-addr=127.0.0.1:46497 --webhook-port=39597 --webhook-cert-dir=/tmp/envtest-serving-certs-2384248205 --feature-gates=MachinePool=false --kubeconfig=/tmp/installer/.clusterapi_output/envtest.kubeconfig]"
time="2024-06-20T19:33:16Z" level=debug msg="I0620 19:33:16.109655   15127 feature_gate.go:249] feature gates: &{map[MachinePool:false]}"
time="2024-06-20T19:33:16Z" level=debug msg="I0620 19:33:16.124024   15127 main.go:413] \"MachinePool=false\\n\" logger=\"setup\""

and the install gets to the machine provisioning stage (which is probably failing because of VM extensions).

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@jhixson74
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@jhixson74
Copy link
Member

/test altinfra-e2e-azure-capi-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit aea78fb into openshift:master Jun 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants