Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/ISSUE_TEMPLATE: Explicitly mention .openshift_install.log #907

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

wking
Copy link
Member

@wking wking commented Dec 14, 2018

We're still getting issue reports about installer crashes that attempt to summarize the issue but do not include copies of the actual error messages. While summaries can be accurate, they're usually not much more compact than a copy/paste of the errors from the logs, and it's a lot easier to find existing reports for a given error if those reports include the error you're looking for.

Also fix some .openshift-install.log -> .openshift_install.log typos from #689.

CC @crawford

These were inconsistencies from 06c5fd3 (openshift-install: log debug
output to file, 2018-11-15, openshift#689).
We're still getting issue reports about installer crashes that attempt
to summarize the issue but do not include copies of the actual error
messages.  While summaries can be accurate, they're usually not much
more compact than a copy/paste of the errors from the logs, and it's a
lot easier to find existing reports for a given error if those reports
include the error you're looking for.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2018
@wking
Copy link
Member Author

wking commented Dec 14, 2018

golint:

2018/12/14 06:41:58 Executing test golint
2018/12/14 06:45:36 Ran for 6m33s
error: could not run steps: failed to wait for test pod to complete: could not wait for pod completion: the pod ci-op-dc9lq727/golint failed after 3m36s (failed containers: ):  unknown

Dunno what that's about.

/test golint

Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e3222c9 into openshift:master Dec 14, 2018
@wking wking deleted the suggest-attaching-logs branch December 14, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants