-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JKNS-458: Add Konflux-compatible Dockerfile #487
base: master
Are you sure you want to change the base?
Conversation
@adambkaplan: This pull request references JKNS-457 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adambkaplan: This pull request references JKNS-458 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Adding a Dockerfile for testing the Jenkins client plugin that does not rely on the OpenShift CI registry for base images. This will pay dividends when we eventually build the Jenkins images and plugins on Konflux, as this Dockerfile only uses productized images published on registry.redhat.io. This also adds a .dockerignore to ensure generated or test content is not present when developers build this image themselves locally. Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
96f595f
to
2cea2ad
Compare
@adambkaplan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adding a Dockerfile for testing the Jenkins client plugin that does not rely on the OpenShift CI registry for base images. This will pay dividends when we eventually build the Jenkins images and plugins on Konflux, as this Dockerfile only uses productized images published on registry.redhat.io.
This also adds a .dockerignore to ensure generated or test content is not present when developers build this image themselves locally.