Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JKNS-458: Add Konflux-compatible Dockerfile #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adambkaplan
Copy link
Contributor

Adding a Dockerfile for testing the Jenkins client plugin that does not rely on the OpenShift CI registry for base images. This will pay dividends when we eventually build the Jenkins images and plugins on Konflux, as this Dockerfile only uses productized images published on registry.redhat.io.

This also adds a .dockerignore to ensure generated or test content is not present when developers build this image themselves locally.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2024

@adambkaplan: This pull request references JKNS-457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Adding a Dockerfile for testing the Jenkins client plugin that does not rely on the OpenShift CI registry for base images. This will pay dividends when we eventually build the Jenkins images and plugins on Konflux, as this Dockerfile only uses productized images published on registry.redhat.io.

This also adds a .dockerignore to ensure generated or test content is not present when developers build this image themselves locally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
Once this PR has been reviewed and has the lgtm label, please assign jkhelil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan adambkaplan changed the title JKNS-457: Add Konflux-compatible Dockerfile JKNS-458: Add Konflux-compatible Dockerfile Jun 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2024

@adambkaplan: This pull request references JKNS-458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Adding a Dockerfile for testing the Jenkins client plugin that does not rely on the OpenShift CI registry for base images. This will pay dividends when we eventually build the Jenkins images and plugins on Konflux, as this Dockerfile only uses productized images published on registry.redhat.io.

This also adds a .dockerignore to ensure generated or test content is not present when developers build this image themselves locally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Adding a Dockerfile for testing the Jenkins client plugin that does not
rely on the OpenShift CI registry for base images. This will pay
dividends when we eventually build the Jenkins images and plugins on
Konflux, as this Dockerfile only uses productized images published on
registry.redhat.io.

This also adds a .dockerignore to ensure generated or test content is
not present when developers build this image themselves locally.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
Copy link

openshift-ci bot commented Jun 21, 2024

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-jenkins-client-plugin 2cea2ad link true /test e2e-aws-jenkins-client-plugin
ci/prow/security 2cea2ad link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants