Remove hardcoded amd64 in build path #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
I think we could also do this fix upstream in @brancz project? |
|
yes let's fix this upstream and then update this downstream fork |
|
@brancz Do you want me to close this, and open a new PR upstream? |
|
Yes, please :) |
|
Closing so I can fork upstream. |
|
we need to merge/rebase this repo with the upstream state now, feel free to create a new PR for this |
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/kube-rbac-proxy
that referenced
this pull request
Jan 10, 2022
Signed-off-by: Song Song Li <ssli@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded 'amd64' so we can build other archs.