Skip to content

Commit

Permalink
Merge pull request kubernetes#123702 from p0lyn0mial/upstream-clean-u…
Browse files Browse the repository at this point in the history
…p-after-123190

storage/cacher: mark the addition of a metric for waitUntilFreshAndBlock as completed
  • Loading branch information
k8s-ci-robot committed Mar 5, 2024
2 parents 13f40e9 + 221ad9f commit 777070c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,6 @@ func (c *Cacher) waitUntilWatchCacheFreshAndForceAllEvents(ctx context.Context,
c.watchCache.waitingUntilFresh.Add()
defer c.watchCache.waitingUntilFresh.Remove()
}
// TODO(p0lyn0mial): add a metric to track the number of times we have failed while waiting
err := c.watchCache.waitUntilFreshAndBlock(ctx, requestedWatchRV)
defer c.watchCache.RUnlock()
return err
Expand Down

0 comments on commit 777070c

Please sign in to comment.