Skip to content

Commit

Permalink
Merge pull request kubernetes#125739 from seans3/ignore-portforward-leak
Browse files Browse the repository at this point in the history
Ignore reported goroutine leak during SPDY shutdown
  • Loading branch information
k8s-ci-robot committed Jun 27, 2024
2 parents 152a0ca + 5ba8773 commit 905fdda
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions test/integration/framework/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,14 @@ func EtcdMain(tests func() int) {
// Both names occurred in practice.
goleak.IgnoreTopFunction("k8s.io/kubernetes/vendor/gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"),
goleak.IgnoreTopFunction("gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"),
// If there is an error during connection shutdown, SPDY keeps a
// goroutine around for ten minutes, which gets reported as a leak
// (the goroutine is cleaned up after the ten minutes).
//
// https://github.com/kubernetes/kubernetes/blob/master/vendor/github.com/moby/spdystream/connection.go#L732-L744
//
// Ignore this reported leak.
goleak.IgnoreTopFunction("github.com/moby/spdystream.(*Connection).shutdown"),
)

stop, err := startEtcd(nil)
Expand Down

0 comments on commit 905fdda

Please sign in to comment.