Skip to content

Commit

Permalink
Merge pull request kubernetes#125755 from saschagrunert/named-param-s…
Browse files Browse the repository at this point in the history
…ervice

Make CRI service interface function arguments consistent
  • Loading branch information
k8s-ci-robot committed Jun 27, 2024
2 parents 24478e0 + 4411a07 commit 95c7621
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions staging/src/k8s.io/cri-api/pkg/apis/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type ContainerManager interface {
// If command exits with a non-zero exit code, an error is returned.
ExecSync(ctx context.Context, containerID string, cmd []string, timeout time.Duration) (stdout []byte, stderr []byte, err error)
// Exec prepares a streaming endpoint to execute a command in the container, and returns the address.
Exec(context.Context, *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
Exec(ctx context.Context, request *runtimeapi.ExecRequest) (*runtimeapi.ExecResponse, error)
// Attach prepares a streaming endpoint to attach to a running container, and returns the address.
Attach(ctx context.Context, req *runtimeapi.AttachRequest) (*runtimeapi.AttachResponse, error)
// ReopenContainerLog asks runtime to reopen the stdout/stderr log file
Expand Down Expand Up @@ -81,7 +81,7 @@ type PodSandboxManager interface {
// ListPodSandbox returns a list of Sandbox.
ListPodSandbox(ctx context.Context, filter *runtimeapi.PodSandboxFilter) ([]*runtimeapi.PodSandbox, error)
// PortForward prepares a streaming endpoint to forward ports from a PodSandbox, and returns the address.
PortForward(context.Context, *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
PortForward(ctx context.Context, request *runtimeapi.PortForwardRequest) (*runtimeapi.PortForwardResponse, error)
}

// ContainerStatsManager contains methods for retrieving the container
Expand Down

0 comments on commit 95c7621

Please sign in to comment.