use an AND to define the allocator readiness

openshift · Jun 27, 2024 · 967ad95 · 967ad95
1 parent fed0517
commit 967ad95
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/registry/core/service/ipallocator/cidrallocator.go b/pkg/registry/core/service/ipallocator/cidrallocator.go
@@ -257,10 +257,10 @@ func (c *MetaAllocator) syncAllocators() error {
 			if c.ipFamily != api.IPFamily(convertToV1IPFamily(netutils.IPFamilyOfCIDRString(cidr))) {
 				continue
 			}
-			// the readiness state of an allocator is an OR of all readiness states
-			ready := true
-			if !isReady(serviceCIDR) || !serviceCIDR.DeletionTimestamp.IsZero() {
-				ready = false
+			// the allocator is ready if the object is ready and is not being deleted
+			ready := false
+			if isReady(serviceCIDR) && serviceCIDR.DeletionTimestamp.IsZero() {
+				ready = true
 			}
 
 			// check if an allocator already exist for this CIDR