Skip to content

Commit

Permalink
Merge pull request kubernetes#119587 from borg-land/node-env-patch
Browse files Browse the repository at this point in the history
Set node-env map parser to nil if an empty string is passed
  • Loading branch information
k8s-ci-robot committed Jul 26, 2023
2 parents a005617 + 7d13c9b commit 98358b8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions build/root/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ define TEST_E2E_NODE_HELP_INFO
# SSH_USER: For REMOTE=true only SSH username to use.
# SSH_KEY: For REMOTE=true only. Path to SSH key to use.
# SSH_OPTIONS: For REMOTE=true only. SSH options to use.
# INSTANCE_TYPE: For REMOTE=true only. Machine type to use.
# NODE_ENV: For REMOTE=true only. Additional metadata keys to add the instance.
# RUNTIME_CONFIG: The runtime configuration for the API server on the node e2e tests.
#
# Example:
Expand Down
3 changes: 3 additions & 0 deletions test/e2e_node/remote/gce/gce_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ func (e *envs) String() string {

// Set function of flag.Value
func (e *envs) Set(value string) error {
if value == "" {
return nil
}
kv := strings.SplitN(value, "=", 2)
if len(kv) != 2 {
return fmt.Errorf("invalid env string %s", value)
Expand Down

0 comments on commit 98358b8

Please sign in to comment.