-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: break kubelet to verify CI #1905
Conversation
@jlebon: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Skipping CI for Draft Pull Request. |
/test ci/prow/e2e-gcp |
@jlebon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will sanity-check in a much more straight-forward way that the kubelet built from PRs is what's actually getting tested in CI. See also openshift#1805 (comment) and following.
@jlebon: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/test e2e-gcp |
We can see in e.g.
So this looks good. We'll redo this test once openshift/release#49156 and #1805 are in. |
/test e2e-gcp |
@jlebon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
🎉 I think we can close this now. |
This will sanity-check in a much more straight-forward way that the kubelet built from PRs is what's actually getting tested in CI.
See also
#1805 (comment) and following.