Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-4229: UPSTREAM:<carry>:bump cadvisor for 3516 upstream patches #2012

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

harche
Copy link

@harche harche commented Jul 4, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it: To bring in google/cadvisor#3516 in OCP

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/MULTIARCH-4229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 4, 2024
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2024

@harche: This pull request references MULTIARCH-4229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it: To bring in google/cadvisor#3516 in OCP 4.17

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/MULTIARCH-4229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from deads2k and soltysh July 4, 2024 18:20
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jul 4, 2024
@harche
Copy link
Author

harche commented Jul 4, 2024

@madeelibm is the PR to bump the cadvisor in OCP 4.17

@madeelibm
Copy link

lgtm

@harche
Copy link
Author

harche commented Jul 8, 2024

/test k8s-e2e-conformance-aws

@haircommander
Copy link
Member

@harche can you retarget this to master? I think master is still forwarding down to 4.18/4.17 so you'll get it here too

@harche harche changed the base branch from release-4.17 to master July 10, 2024 14:45
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2024

@harche: This pull request references MULTIARCH-4229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it: To bring in google/cadvisor#3516 in OCP 4.17

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/MULTIARCH-4229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@harche
Copy link
Author

harche commented Jul 10, 2024

@harche can you retarget this to master? I think master is still forwarding down to 4.18/4.17 so you'll get it here too

Done. let's see if it builds successfully.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2024

@harche: This pull request references MULTIARCH-4229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it: To bring in google/cadvisor#3516 in OCP

Which issue(s) this PR fixes:

Fixes # https://issues.redhat.com/browse/MULTIARCH-4229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@madeelibm
Copy link

/retest

@madeelibm
Copy link

@harche verify-commits is failing due to commit message. See below:

UPSTREAM commit c8bc7a48e19 has invalid summary UPSTREAM:<carry>:bump cadvisor for 3516 upstream patches.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

UPSTREAM: <PR number|carry|drop>: description

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

openshift-ci bot commented Jul 11, 2024

@harche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@mrunalp mrunalp added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jul 15, 2024
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harche, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harche, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link

/label acknowledge-critical-fixes-only

This should be extremely safe as it brings in s390 support.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 27bcad5 into openshift:master Jul 15, 2024
20 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.17.0-202407152240.p0.g27bcad5.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants