-
Notifications
You must be signed in to change notification settings - Fork 217
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cert-rotation: allow specifying multiple target certs in CertRotation…
…Controller Instead of defining several controllers managing the same signer/CA bundle pair and different target certs the same controller can accept a list of target certs to create.
- Loading branch information
Showing
2 changed files
with
331 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
263 changes: 263 additions & 0 deletions
263
pkg/operator/certrotation/client_cert_rotation_controller_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,263 @@ | ||
| package certrotation | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/davecgh/go-spew/spew" | ||
| "github.com/openshift/library-go/pkg/controller/factory" | ||
| "github.com/openshift/library-go/pkg/operator/events" | ||
| "github.com/openshift/library-go/pkg/operator/events/eventstesting" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/informers" | ||
| kubefake "k8s.io/client-go/kubernetes/fake" | ||
| corev1listers "k8s.io/client-go/listers/core/v1" | ||
| clienttesting "k8s.io/client-go/testing" | ||
| "k8s.io/client-go/tools/cache" | ||
| ) | ||
|
|
||
| type fakeStatusReporter struct{} | ||
|
|
||
| func (f *fakeStatusReporter) Report(ctx context.Context, controllerName string, syncErr error) (updated bool, updateErr error) { | ||
| return false, nil | ||
| } | ||
|
|
||
| func TestCertRotationController(t *testing.T) { | ||
| indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc}) | ||
| client := kubefake.NewSimpleClientset() | ||
| controllerCtx, cancel := context.WithCancel(context.Background()) | ||
|
|
||
| ns, signerName, caName, targetName := "ns", "test-signer", "test-ca", "test-target" | ||
| eventRecorder := events.NewInMemoryRecorder("test") | ||
| additionalAnnotations := AdditionalAnnotations{ | ||
| JiraComponent: "test", | ||
| } | ||
| owner := &metav1.OwnerReference{ | ||
| Name: "operator", | ||
| } | ||
|
|
||
| informerFactory := informers.NewSharedInformerFactoryWithOptions(client, 1*time.Minute, informers.WithNamespace(ns)) | ||
|
|
||
| signerSecret := RotatedSigningCASecret{ | ||
| Namespace: ns, | ||
| Name: signerName, | ||
| Validity: 24 * time.Hour, | ||
| Refresh: 12 * time.Hour, | ||
| Client: client.CoreV1(), | ||
| Lister: corev1listers.NewSecretLister(indexer), | ||
| Informer: informerFactory.Core().V1().Secrets(), | ||
| EventRecorder: eventRecorder, | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| UseSecretUpdateOnly: true, | ||
| } | ||
| caBundleConfigMap := CABundleConfigMap{ | ||
| Namespace: ns, | ||
| Name: caName, | ||
| Client: client.CoreV1(), | ||
| Lister: corev1listers.NewConfigMapLister(indexer), | ||
| EventRecorder: eventRecorder, | ||
| Informer: informerFactory.Core().V1().ConfigMaps(), | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| } | ||
| targetSecret := RotatedSelfSignedCertKeySecret{ | ||
| Name: targetName, | ||
| Namespace: ns, | ||
| Validity: 24 * time.Hour, | ||
| Refresh: 12 * time.Hour, | ||
| CertCreator: &ServingRotation{ | ||
| Hostnames: func() []string { return []string{"foo", "bar"} }, | ||
| }, | ||
| Client: client.CoreV1(), | ||
| Informer: informerFactory.Core().V1().Secrets(), | ||
| Lister: corev1listers.NewSecretLister(indexer), | ||
| EventRecorder: eventRecorder, | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| UseSecretUpdateOnly: true, | ||
| } | ||
|
|
||
| c := NewCertRotationController("operator", signerSecret, caBundleConfigMap, targetSecret, eventRecorder, &fakeStatusReporter{}) | ||
|
|
||
| time.AfterFunc(1*time.Second, func() { | ||
| cancel() | ||
| }) | ||
| c.Run(controllerCtx, 1) | ||
|
|
||
| syncCtx := factory.NewSyncContext("test", eventstesting.NewTestingEventRecorder(t)) | ||
| err := c.Sync(controllerCtx, syncCtx) | ||
| if err != nil { | ||
| t.Errorf("sync error: %v", err) | ||
| } | ||
|
|
||
| actions := client.Actions() | ||
| if len(actions) != 6 { | ||
| t.Fatal(spew.Sdump(actions)) | ||
| } | ||
|
|
||
| if !actions[0].Matches("get", "secrets") { | ||
| t.Error(actions[0]) | ||
| } | ||
| if !actions[1].Matches("create", "secrets") { | ||
| t.Error(actions[1]) | ||
| } | ||
| if !actions[2].Matches("get", "configmaps") { | ||
| t.Error(actions[2]) | ||
| } | ||
| if !actions[3].Matches("create", "configmaps") { | ||
| t.Error(actions[3]) | ||
| } | ||
| if !actions[4].Matches("get", "secrets") { | ||
| t.Error(actions[4]) | ||
| } | ||
| if !actions[5].Matches("create", "secrets") { | ||
| t.Error(actions[5]) | ||
| } | ||
| actualSignerSecret := actions[1].(clienttesting.CreateAction).GetObject().(*corev1.Secret) | ||
| if actualSignerSecret.Name != signerName { | ||
| t.Errorf("expected signer secret name to be %s, got %s", signerName, actualSignerSecret.Name) | ||
| } | ||
| actualCABundleConfigMap := actions[3].(clienttesting.CreateAction).GetObject().(*corev1.ConfigMap) | ||
| if actualCABundleConfigMap.Name != caName { | ||
| t.Errorf("expected CA bundle configmap name to be %s, got %s", signerName, actualCABundleConfigMap.Name) | ||
| } | ||
| actualTargetSecret := actions[5].(clienttesting.CreateAction).GetObject().(*corev1.Secret) | ||
| if actualTargetSecret.Name != targetName { | ||
| t.Errorf("expected target secret name to be %s, got %s", signerName, actualTargetSecret.Name) | ||
| } | ||
| } | ||
|
|
||
| func TestCertRotationControllerMultipleTargets(t *testing.T) { | ||
| indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc}) | ||
| client := kubefake.NewSimpleClientset() | ||
| controllerCtx, cancel := context.WithCancel(context.Background()) | ||
|
|
||
| ns, signerName, caName, targetFirstName, targetSecondName := "ns", "test-signer", "test-ca", "test-target-one", "test-target-two" | ||
| eventRecorder := events.NewInMemoryRecorder("test") | ||
| additionalAnnotations := AdditionalAnnotations{ | ||
| JiraComponent: "test", | ||
| } | ||
| owner := &metav1.OwnerReference{ | ||
| Name: "operator", | ||
| } | ||
|
|
||
| informerFactory := informers.NewSharedInformerFactoryWithOptions(client, 1*time.Minute, informers.WithNamespace(ns)) | ||
|
|
||
| signerSecret := RotatedSigningCASecret{ | ||
| Namespace: ns, | ||
| Name: signerName, | ||
| Validity: 24 * time.Hour, | ||
| Refresh: 12 * time.Hour, | ||
| Client: client.CoreV1(), | ||
| Lister: corev1listers.NewSecretLister(indexer), | ||
| Informer: informerFactory.Core().V1().Secrets(), | ||
| EventRecorder: eventRecorder, | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| UseSecretUpdateOnly: true, | ||
| } | ||
| caBundleConfigMap := CABundleConfigMap{ | ||
| Namespace: ns, | ||
| Name: caName, | ||
| Client: client.CoreV1(), | ||
| Lister: corev1listers.NewConfigMapLister(indexer), | ||
| EventRecorder: eventRecorder, | ||
| Informer: informerFactory.Core().V1().ConfigMaps(), | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| } | ||
| targetFirstSecret := RotatedSelfSignedCertKeySecret{ | ||
| Name: targetFirstName, | ||
| Namespace: ns, | ||
| Validity: 24 * time.Hour, | ||
| Refresh: 12 * time.Hour, | ||
| CertCreator: &ServingRotation{ | ||
| Hostnames: func() []string { return []string{"foo", "bar"} }, | ||
| }, | ||
| Client: client.CoreV1(), | ||
| Informer: informerFactory.Core().V1().Secrets(), | ||
| Lister: corev1listers.NewSecretLister(indexer), | ||
| EventRecorder: eventRecorder, | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| UseSecretUpdateOnly: true, | ||
| } | ||
| targetSecondSecret := RotatedSelfSignedCertKeySecret{ | ||
| Name: targetSecondName, | ||
| Namespace: ns, | ||
| Validity: 24 * time.Hour, | ||
| Refresh: 12 * time.Hour, | ||
| CertCreator: &ServingRotation{ | ||
| Hostnames: func() []string { return []string{"foo", "bar"} }, | ||
| }, | ||
| Client: client.CoreV1(), | ||
| Informer: informerFactory.Core().V1().Secrets(), | ||
| Lister: corev1listers.NewSecretLister(indexer), | ||
| EventRecorder: eventRecorder, | ||
| AdditionalAnnotations: additionalAnnotations, | ||
| Owner: owner, | ||
| UseSecretUpdateOnly: true, | ||
| } | ||
|
|
||
| c := NewCertRotationControllerMultipleTargets("operator", signerSecret, caBundleConfigMap, []RotatedSelfSignedCertKeySecret{targetFirstSecret, targetSecondSecret}, eventRecorder, &fakeStatusReporter{}) | ||
|
|
||
| time.AfterFunc(1*time.Second, func() { | ||
| cancel() | ||
| }) | ||
| c.Run(controllerCtx, 1) | ||
|
|
||
| syncCtx := factory.NewSyncContext("test", eventstesting.NewTestingEventRecorder(t)) | ||
| err := c.Sync(controllerCtx, syncCtx) | ||
| if err != nil { | ||
| t.Errorf("sync error: %v", err) | ||
| } | ||
|
|
||
| actions := client.Actions() | ||
| if len(actions) != 8 { | ||
| t.Fatal(spew.Sdump(actions)) | ||
| } | ||
|
|
||
| if !actions[0].Matches("get", "secrets") { | ||
| t.Error(actions[0]) | ||
| } | ||
| if !actions[1].Matches("create", "secrets") { | ||
| t.Error(actions[1]) | ||
| } | ||
| if !actions[2].Matches("get", "configmaps") { | ||
| t.Error(actions[2]) | ||
| } | ||
| if !actions[3].Matches("create", "configmaps") { | ||
| t.Error(actions[3]) | ||
| } | ||
| if !actions[4].Matches("get", "secrets") { | ||
| t.Error(actions[4]) | ||
| } | ||
| if !actions[5].Matches("create", "secrets") { | ||
| t.Error(actions[5]) | ||
| } | ||
| if !actions[6].Matches("get", "secrets") { | ||
| t.Error(actions[6]) | ||
| } | ||
| if !actions[7].Matches("create", "secrets") { | ||
| t.Error(actions[7]) | ||
| } | ||
| actualSignerSecret := actions[1].(clienttesting.CreateAction).GetObject().(*corev1.Secret) | ||
| if actualSignerSecret.Name != signerName { | ||
| t.Errorf("expected signer secret name to be %s, got %s", signerName, actualSignerSecret.Name) | ||
| } | ||
| actualCABundleConfigMap := actions[3].(clienttesting.CreateAction).GetObject().(*corev1.ConfigMap) | ||
| if actualCABundleConfigMap.Name != caName { | ||
| t.Errorf("expected CA bundle configmap name to be %s, got %s", signerName, actualCABundleConfigMap.Name) | ||
| } | ||
| actualFirstTargetSecret := actions[5].(clienttesting.CreateAction).GetObject().(*corev1.Secret) | ||
| if actualFirstTargetSecret.Name != targetFirstName { | ||
| t.Errorf("expected first target secret name to be %s, got %s", signerName, actualFirstTargetSecret.Name) | ||
| } | ||
| actualSecondTargetSecret := actions[7].(clienttesting.CreateAction).GetObject().(*corev1.Secret) | ||
| if actualSecondTargetSecret.Name != targetSecondName { | ||
| t.Errorf("expected second target secret name to be %s, got %s", signerName, actualFirstTargetSecret.Name) | ||
| } | ||
| } |