Fix test-e2e-encryption rule #1470

dgrisonnet · 2023-02-17T14:28:20Z

The test-e2e-encryption rule was broken which caused the e2e-aws-encryption CI job to not do anything. For instance, if we look at the job logs, the make test-e2e-encryption invocation is yielding the following error:

make: Nothing to be done for 'test-e2e-encryption'.

The intended way to run these test seem to call the test-unit rule from build-machinery: https://github.com/openshift/build-machinery-go/blob/bd58a901bbfeb5f63f027cfaa35de4863bb535fb/make/targets/golang/test-unit.mk#L5-L13. And that is what we are doing today in cluster-kube-apiserver-operator: https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/Makefile#L39-L60.

Alongside this fix, I also added the flags that we are setting in the kas-operator repo as they seem to be a good fit for this test aswell.

dgrisonnet · 2023-02-17T14:33:50Z

As explained in #1469 (comment), this test seems to have been broken in CI since the time it was first added, because the Makefile rule never did anything.

dgrisonnet · 2023-02-17T14:36:33Z

/test e2e-aws-encryption

tkashem · 2023-02-17T14:40:57Z

/lgtm
/approve

Thanks !

tkashem · 2023-02-17T14:51:57Z

/assign @sttts (for approval)

sttts · 2023-02-17T14:53:50Z

/approve

openshift-ci · 2023-02-17T15:07:40Z

New changes are detected. LGTM label has been removed.

dgrisonnet · 2023-02-17T15:09:46Z

There was a compilation error in the test, I fixed it in the latest commit.

/retest

openshift-bot · 2023-05-19T01:01:06Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-06-18T08:31:02Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-07-19T00:01:05Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-07-19T00:03:15Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dgrisonnet · 2024-10-16T13:32:28Z

/reopen

dgrisonnet · 2024-10-16T13:32:42Z

/remove-lifecycle rotten

openshift-ci · 2024-10-16T13:32:50Z

@dgrisonnet: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-10-16T13:33:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrisonnet, sttts, tkashem
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

p0lyn0mial · 2024-10-16T14:17:03Z

/test e2e-aws-encryption

Run the test-unit rule that was initially forgotten and add the same flags as the ones we are using in cluster-kube-apiserver-operator tests. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>

p0lyn0mial · 2024-10-17T07:31:09Z

Makefile

@@ -24,6 +24,10 @@ verify-podnetworkconnectivitychecks:
 	$(MAKE) -C pkg/operator/connectivitycheckcontroller verify

 test-e2e-encryption: GO_TEST_PACKAGES :=./test/e2e-encryption/...
+test-e2e-encryption: GO_TEST_FLAGS += -v
+test-e2e-encryption: GO_TEST_FLAGS += -timeout 4h


4h for a single unit test is quite a long timeout :)

This is mostly copied from https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/Makefile#L45-L48.

And there nothing unit about this test besides the fact that we invoke "test-unit" from build-machinery. The test creates 7 different keys: https://github.com/openshift/library-go/blob/master/test/e2e-encryption/encryption_test.go#L366-L371 which should result in at least 21 revisions if we include the migrations, which can take a while 😅

p0lyn0mial · 2024-10-17T07:31:22Z

Makefile

@@ -24,6 +24,10 @@ verify-podnetworkconnectivitychecks:
 	$(MAKE) -C pkg/operator/connectivitycheckcontroller verify

 test-e2e-encryption: GO_TEST_PACKAGES :=./test/e2e-encryption/...
+test-e2e-encryption: GO_TEST_FLAGS += -v
+test-e2e-encryption: GO_TEST_FLAGS += -timeout 4h
+test-e2e-encryption: GO_TEST_FLAGS += -p 1


is this required ?

Not right now since there is only one test in the package, but it can be a great protection in the future if we add another test as it would prevent running different encryption changes in parallel against the same cluster.

Based on that, do you think we should keep it?

p0lyn0mial · 2024-10-17T07:34:23Z

test/e2e-encryption/encryption_test.go

@@ -628,3 +638,34 @@ func (p *provider) EncryptedGRs() []schema.GroupResource {
 func (p *provider) ShouldRunEncryptionControllers() (bool, error) {
 	return true, nil
 }
+
+func extractOperatorSpec(obj *unstructured.Unstructured, fieldManager string) (*applyoperatorv1.OperatorSpecApplyConfiguration, error) {
+	castObj := &operatorv1.OpenShiftAPIServer{}


isn't the test using some fake resource ?

correct 🤦‍♂️, I blindly copy-pasted these and didn't check

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>

openshift-ci · 2024-10-17T19:30:16Z

@dgrisonnet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-encryption	`d440f32`	link	true	`/test e2e-aws-encryption`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-01-16T01:00:25Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2025-02-15T08:30:15Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-ci bot requested review from deads2k and sttts February 17, 2023 14:28

openshift-ci bot assigned tkashem Feb 17, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 17, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2023

openshift-ci bot closed this Jul 19, 2023

dgrisonnet mentioned this pull request Oct 16, 2024

fix: Set resource version for CRs #1823

Merged

openshift-ci bot reopened this Oct 16, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 16, 2024

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024

dgrisonnet force-pushed the encryption-makefile branch from ef8c1a0 to 1e1f254 Compare October 16, 2024 13:34

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024

Fix test-e2e-encryption rule

96e34fd

Run the test-unit rule that was initially forgotten and add the same flags as the ones we are using in cluster-kube-apiserver-operator tests. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>

dgrisonnet force-pushed the encryption-makefile branch from 1e1f254 to 22a5ab6 Compare October 17, 2024 07:01

p0lyn0mial reviewed Oct 17, 2024

View reviewed changes

test/e2e-encryption: fix compilation

00f3d78

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>

dgrisonnet force-pushed the encryption-makefile branch from 22a5ab6 to 00f3d78 Compare October 17, 2024 10:04

test/e2e-encryption: update test CRD to v1

d440f32

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2025

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix test-e2e-encryption rule #1470

Fix test-e2e-encryption rule #1470

dgrisonnet commented Feb 17, 2023 •

edited

Loading

dgrisonnet commented Feb 17, 2023 •

edited

Loading

dgrisonnet commented Feb 17, 2023

tkashem commented Feb 17, 2023

tkashem commented Feb 17, 2023

sttts commented Feb 17, 2023

openshift-ci bot commented Feb 17, 2023

dgrisonnet commented Feb 17, 2023

openshift-bot commented May 19, 2023

openshift-bot commented Jun 18, 2023

openshift-bot commented Jul 19, 2023

openshift-ci bot commented Jul 19, 2023

dgrisonnet commented Oct 16, 2024

dgrisonnet commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

p0lyn0mial commented Oct 16, 2024

p0lyn0mial Oct 17, 2024

dgrisonnet Oct 17, 2024

p0lyn0mial Oct 17, 2024

dgrisonnet Oct 17, 2024

p0lyn0mial Oct 17, 2024

dgrisonnet Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

openshift-bot commented Jan 16, 2025

openshift-bot commented Feb 15, 2025

Fix test-e2e-encryption rule #1470

Are you sure you want to change the base?

Fix test-e2e-encryption rule #1470

Conversation

dgrisonnet commented Feb 17, 2023 • edited Loading

dgrisonnet commented Feb 17, 2023 • edited Loading

dgrisonnet commented Feb 17, 2023

tkashem commented Feb 17, 2023

tkashem commented Feb 17, 2023

sttts commented Feb 17, 2023

openshift-ci bot commented Feb 17, 2023

dgrisonnet commented Feb 17, 2023

openshift-bot commented May 19, 2023

openshift-bot commented Jun 18, 2023

openshift-bot commented Jul 19, 2023

openshift-ci bot commented Jul 19, 2023

dgrisonnet commented Oct 16, 2024

dgrisonnet commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

p0lyn0mial commented Oct 16, 2024

p0lyn0mial Oct 17, 2024

Choose a reason for hiding this comment

dgrisonnet Oct 17, 2024

Choose a reason for hiding this comment

p0lyn0mial Oct 17, 2024

Choose a reason for hiding this comment

dgrisonnet Oct 17, 2024

Choose a reason for hiding this comment

p0lyn0mial Oct 17, 2024

Choose a reason for hiding this comment

dgrisonnet Oct 17, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Oct 17, 2024

openshift-bot commented Jan 16, 2025

openshift-bot commented Feb 15, 2025

dgrisonnet commented Feb 17, 2023 •

edited

Loading

dgrisonnet commented Feb 17, 2023 •

edited

Loading