Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in service monitor sync #168

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix panic in service monitor sync #168

merged 1 commit into from
Jan 14, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 11, 2019

sa sync was never set, so we paniced

/assign @mfojtik @damemi

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
@wking wking mentioned this pull request Jan 12, 2019
Merged
@wking
Copy link
Member

wking commented Jan 12, 2019

Is this the source of:

panic: osins.osin.openshift.io "openshift-osin" is forbidden: caches not synchronized

goroutine 85 [running]:
github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/operator/v1helpers.EnsureOperatorConfigExists(0x1c2bf60, 0xc4200e6430, 0xc4208e2000, 0x91, 0xa0, 0x1a5e164, 0x11, 0x1a529f5, 0x8, 0x1a4e7be, ...)
	/go/src/github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/operator/v1helpers/helpers.go:99 +0x34e

?

@wking wking mentioned this pull request Jan 12, 2019
Merged
sttts
sttts reviewed Jan 14, 2019
View reviewed changes
pkg/operator/staticpod/controller/monitoring/monitoring_resource_controller.go Outdated
clusterRoleBindingLister rbaclisterv1.ClusterRoleBindingLister
clusterRoleBindingListerSynced cache.InformerSynced
clusterRoleBindingLister rbaclisterv1.ClusterRoleBindingLister
preRunCachesSynced []cache.InformerSynced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically the PR is good. But this field name needs to be changed or at least needs a good go doc. What does "preRun" mean?

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Jan 14, 2019

doc updated

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5cf5619 into openshift:master Jan 14, 2019
@wking wking mentioned this pull request Jan 14, 2019
Closed
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
@openshift-merge-robot
Merge pull request openshift#168 from deads2k/fixpanic
ecd731f 
fix panic in service monitor sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @openshift-ci-robot @wking @sttts @mfojtik @damemi @openshift-merge-robot