Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Communication Matrix Module #1716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sabinaaledort
Copy link

@sabinaaledort sabinaaledort commented Apr 14, 2024

This commit adds a new module to generate a communication matrix.
The communication matrix lists the open ports in the cluster and
provides different formats to print the results.

Use the /pkg/network/commatrix/Makefile to generate the matrix.
The OUTPUT variable is the desired output format, which can be set to YAML, CSV,
or JSON.
The CLUSTER_ENV variable is the environment in which the cluster is deployed;
currently, it can be set to either baremetal or aws.

@openshift-ci openshift-ci bot requested review from deads2k and soltysh April 14, 2024 15:47
Copy link
Contributor

openshift-ci bot commented Apr 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sabinaaledort
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liornoy and others added 2 commits April 15, 2024 14:16
This commit adds a new module for generating a communication matrix.
The communication matrix lists the open ports in the cluster and
provides different formats to print the results.

Use the `/pkg/network/commatrix/cmd/Makefile` to generate the matrix.
The OUTPUT variable is the desired output format, which can be set to YAML, CSV,
or JSON.
The CLUSTER_ENV variable is the environment in which the cluster is deployed;
currently, it can be set to either `baremetal` or `aws`.
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@sabinaaledort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 824c8c1 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants