operator/certrotation: introduce an optional lock to CABundleConfigMap and RotatedSigningCASecret #1752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve the current behaviour and make the controllers thread safe
I've decided to introduce an optional mutex which can be used when the instance
is shared across multiple controllers.
This approach requires the fewest changes and resolves the race condition.
I think even a simpler version of this approach would work: #1753
Perhaps the best approach would be to create separate controllers for
CABundleConfigMap
andRotatedSigningCASecret
.I've also opened a proof PR at openshift/cluster-kube-apiserver-operator#1709
Alternative for #1722