OCPBUGS-34373: routes/custom-host permission update for externalCertificate

[chiragkyal]

• “create” is required to set spec.tls.externalCertificate on route creation

• either “create” or “update” is required to update spec.tls.externalCertificate

• Note: since the state of the external secret cannot be verified, even keeping the secret name unchanged, requires permission check.

• NO PERMISSION is required to remove spec.tls.externalCertificate

• EP changes OCPBUGS-34373: routes/custom-host permission update for externalCertificate enhancements#1652

The decision was taken based on openshift/origin#18177 (comment) discussion on custom-host permission and keep it identical with the existing spec.tls.Certificate field.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@chiragkyal: This pull request references Jira Issue OCPBUGS-34373, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• “create” is required to set spec.tls.externalCertificate on route creation

• either “create” or “update” is required to update spec.tls.externalCertificate

• Note: since the state of the external secret cannot be verified, even keeping the secret name unchanged, requires permission check.

• NO PERMISSION is required to remove spec.tls.externalCertificate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[chiragkyal]

/assign @alebedev87 @Miciah

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiragkyal
Once this PR has been reviewed and has the lgtm label, please ask for approval from miciah. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/route/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.