Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42535-prime: prevent conditions missing information #1803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Open

OCPBUGS-42535-prime: prevent conditions missing information #1803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/operator/genericoperatorclient/dynamic_operator_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,18 @@ func (c dynamicOperatorClient) UpdateOperatorSpec(ctx context.Context, resourceV
// in operatorv1.OperatorStatus while preserving pre-existing status fields that have
// no correspondence in operatorv1.OperatorStatus.
func (c dynamicOperatorClient) UpdateOperatorStatus(ctx context.Context, resourceVersion string, status *operatorv1.OperatorStatus) (*operatorv1.OperatorStatus, error) {
if status != nil {
for i, curr := range status.Conditions {
// panicking so we can quickly find it and fix the source
if len(curr.Type) == 0 {
panic(fmt.Sprintf(".status.conditions[%d].type is missing", i))
}
if len(curr.Status) == 0 {
panic(fmt.Sprintf(".status.conditions[%q].status is missing", curr.Type))
}
}
}

uncastOriginal, err := c.informer.Lister().Get(c.configName)
if err != nil {
return nil, err
Expand Down