-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine cabundle configmaps #191
combine cabundle configmaps #191
Conversation
I suspect we end up making a simple control loop for this, but I guess we'll see. |
"github.com/openshift/library-go/pkg/operator/events" | ||
) | ||
|
||
func CombineCABundleConfigMaps(destinationConfigMap ResourceLocation, lister corev1listers.ConfigMapLister, client corev1client.ConfigMapsGetter, recorder events.Recorder, inputConfigMaps ...ResourceLocation) (*corev1.ConfigMap, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nite: don't hate godoc
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
combine cabundle configmaps
This is the logic we use the kube-apiserver to combine ca-bundle configmaps
/assign @mfojtik